-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix k8s metadata issue #16834
Fix k8s metadata issue #16834
Conversation
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Pinging @elastic/integrations-platforms (Team:Platforms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this change for 8.0, but I am not sure of seeing the advantages of backporting this to 7.x versions.
Has there been any update on this issue? This is a significant breaking change moving to 7.6.x and it makes it impossible for us to group nodes or pods by kubernetes cluster. |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach seems acceptable to me, at least until 8.0.
LGTM! |
I understand that after the latest updates we are fine with backporting this, right @jsoriano? |
Looks good now, yes. Thanks! |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
(cherry picked from commit 034ee55)
(cherry picked from commit 034ee55)
What does this PR do?
This PR fixes labels in k8s metadata. Issues found in 7.6 version: https://discuss.elastic.co/t/how-to-get-kubernetes-node-labels-with-metricbeat/220667/6
The proposed solution is to addkubernetes.labels.*
in all resources (node
,namespace
etc) so as to cover cases likenode
metricset. Also whennode
,namespace
, are part of other resources likepod
then their labels are part of the sub-resource and not the main resource.The proposed solution is to add
kubernetes.labels.*
innode
resources so as to cover cases likenode
metricset. Also whennode
, is part of other resources likepod
then their labels are part of the sub-resource and not the main resource.Example with
node
as main resource :Example with sub-resources:
Why is it important?
Currently the metadata are not populated properly.
Checklist
How to test this PR locally
TBA
Related issues