Update fields.ecs.yml to ECS v1.5.0 #16900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansr
changed the title
|
Pinging @elastic/siem (Team:SIEM) |
andrewkroh
approved these changes
Mar 10, 2020
|
jenkins, test this |
|
jenkins, test this |
Fields' docs generation is failing in some systems when non-ascii characters appear in the fields descriptions and/or examples.
Changes in generators caused examples to be serialised differently
The fields docs generator was having trouble representing an example as an object in a way that was consistent across different python3 versions due to keys in a dict being serialised to string with different orderings. This caused checks to fail.
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 16, 2020
* Update vendored elastic/ecs to v1.5.0 * Update fields.ecs.yml to v1.5.0 * Fix encoding issue in fields' docs Fields' docs generation is failing in some systems when non-ascii characters appear in the fields descriptions and/or examples. * Patch fields.ecs.yml to avoid parser trouble The fields docs generator was having trouble representing an example as an object in a way that was consistent across different python3 versions due to keys in a dict being serialised to string with different orderings. This caused checks to fail. (cherry picked from commit 76dcd34)
adriansr
added a commit
that referenced
this pull request
Mar 17, 2020
* Update vendored elastic/ecs to v1.5.0 * Update fields.ecs.yml to v1.5.0 * Fix encoding issue in fields' docs Fields' docs generation is failing in some systems when non-ascii characters appear in the fields descriptions and/or examples. * Patch fields.ecs.yml to avoid parser trouble The fields docs generator was having trouble representing an example as an object in a way that was consistent across different python3 versions due to keys in a dict being serialised to string with different orderings. This caused checks to fail. (cherry picked from commit 76dcd34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the fields.yml and generated Go code to ECS v1.5.0.
Why is it important?
So we can update Beats to ship data using 1.5 fields.
Why no changelog entry?
Because this update doesn't impact the user until we start adding/updating data sources that populate those fields.