[Agent] Fixed test to pass on windows #16922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ingest-management (Project:fleet) |
ph
reviewed
Mar 10, 2020
| } | ||
| // if runtime.GOOS == "windows" && c.SkipWindows { | ||
| // t.Skip("Skipped under windows") | ||
| // } |
There was a problem hiding this comment.
i bet i did, i had to press ctrlz
ph
approved these changes
Mar 10, 2020
ph
pushed a commit
to ph/beats
that referenced
this pull request
Apr 7, 2020
[Agent] Fixed test to pass on windows (elastic#16922) (cherry picked from commit cfcae9d)
ph
added
v7.8.0
and removed
needs_backport
ph
added a commit
that referenced
this pull request
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Funny behavior of
filepath.Dircaused drop test to fail.Monitoring tests failed due to mixup in build tags.
Fixes: #16854