Fix Elasticsearch GC logs ingestion from Docker logs #17164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used with docker autodiscover, the elasticsearch gc module
erroneously picks up JSON formatted line from docker's stdout.
Fix by excluding lines that start with `{`.
ycombinator
added
bug
Filebeat
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
ycombinator
added
module
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
kaiyan-sheng
approved these changes
Mar 24, 2020
|
Travis CI is green and Jenkins CI failures are unrelated. Merging. |
This was referenced Mar 24, 2020
ycombinator
removed
the
needs_backport
ycombinator
added a commit
that referenced
this pull request
Mar 24, 2020
* [Filebeat][elasticsearch] fix JSON lines picked up in gc.logs
When used with docker autodiscover, the elasticsearch gc module
erroneously picks up JSON formatted line from docker's stdout.
Fix by excluding lines that start with `{`.
* Adding test files
* Adding CHANGELOG entry
* Moving test files to correct fileset
* Introduce GC log entry in test fixture + golden file
* Make sure multiline pattern excludes lines starting with {
* Fixing golden file
Co-authored-by: Magnus Kessler <magnus.kessler@elastic.co>
Co-authored-by: Magnus Kessler <magnus.kessler@elastic.co>
ycombinator
added a commit
that referenced
this pull request
Mar 25, 2020
…17207) * Fix Elasticsearch GC logs ingestion from Docker logs (#17164) * [Filebeat][elasticsearch] fix JSON lines picked up in gc.logs When used with docker autodiscover, the elasticsearch gc module erroneously picks up JSON formatted line from docker's stdout. Fix by excluding lines that start with `{`. * Adding test files * Adding CHANGELOG entry * Moving test files to correct fileset * Introduce GC log entry in test fixture + golden file * Make sure multiline pattern excludes lines starting with { * Fixing golden file Co-authored-by: Magnus Kessler <magnus.kessler@elastic.co> * Cleaning up CHANGELOG * Removing event.{kind,category,type} fields (only available starting 7.7) Co-authored-by: Magnus Kessler <magnus.kessler@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the ingestion of Elasticsearch GC logs when Elasticsearch is running in Docker.
Why is it important?
Before this PR, the
elasticsearch.gcfileset was collecting all Elasticsearch logs emitted by the Docker container running Elasticsearch.Checklist
I have made corresponding changes to the documentationRelated issues
gcfileset collects non-GC logs in container environment #16583