Allow a wider range of characters for logstash.log.pipeline_id #17243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a wider range of characters for `logstash.log.pipeline_id`. The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer. Should solve #17242
ycombinator
reviewed
Mar 25, 2020
ycombinator
added
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
ycombinator
added
needs_backport
zube
bot
added
[zube]: In Progress
[zube]: In Review
and removed
[zube]: In Review
[zube]: In Progress
labels
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
|
I've patched the test with the correct values, let's wait for the CI. |
|
Hey @lucabelluccini, CI is looking good on these changes. Travis CI is green and Jenkins CI failures are unrelated. Could you add an entry in |
|
|
|
Thanks for fixing this @lucabelluccini |
ycombinator
approved these changes
Mar 30, 2020
This was referenced Mar 30, 2020
ycombinator
removed
the
needs_backport
ycombinator
added a commit
that referenced
this pull request
Mar 30, 2020
…17243) (#17338) * Allow a wider range of characters for logstash.log.pipeline_id (#17243) * Allow a wider range of characters for logstash.log.pipeline_id Allow a wider range of characters for `logstash.log.pipeline_id`. The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer. Should solve #17242 * update tests for logstash plain 7.4 pipeline id * Failed tests * update changelog * CHANGELOG grooming Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
ycombinator
added a commit
that referenced
this pull request
Mar 31, 2020
…17243) (#17357) * Allow a wider range of characters for logstash.log.pipeline_id (#17243) * Allow a wider range of characters for logstash.log.pipeline_id Allow a wider range of characters for `logstash.log.pipeline_id`. The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer. Should solve #17242 * update tests for logstash plain 7.4 pipeline id * Failed tests * update changelog * CHANGELOG grooming Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
ycombinator
added a commit
that referenced
this pull request
Apr 2, 2020
…17243) (#17339) * Allow a wider range of characters for logstash.log.pipeline_id (#17243) * Allow a wider range of characters for logstash.log.pipeline_id Allow a wider range of characters for `logstash.log.pipeline_id`. The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer. Should solve #17242 * update tests for logstash plain 7.4 pipeline id * Failed tests * update changelog * CHANGELOG grooming * Removing fields that are not available in Filebeat 7.6 Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#17243) (elastic#17357) * Allow a wider range of characters for logstash.log.pipeline_id (elastic#17243) * Allow a wider range of characters for logstash.log.pipeline_id Allow a wider range of characters for `logstash.log.pipeline_id`. The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer. Should solve elastic#17242 * update tests for logstash plain 7.4 pipeline id * Failed tests * update changelog * CHANGELOG grooming Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow a wider range of characters for
logstash.log.pipeline_id.The
NOTSPACEshould be fine, but for covering any case,DATAwould be safer.Why is it important?
Should solve #17242
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues