-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Metricbeat azure module to GA and add final tests #17319
Conversation
Pinging @elastic/integrations (Team:Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, but it's not testing the fields that come out of the different metricsets
I think it's ok for the lightweight metricsets as you only need to test that in monitor
, but the rest need some more checks
@exekias , regarding:
The field mapping for the other native metricsets looks like this (ex.):
No other fields but the ones the dynamic mapping covers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed on keep adding tests here: #17315
* temp * add tests and move to GA * changelog * fix (cherry picked from commit 2bb6fc9)
* temp * add tests and move to GA * changelog * fix (cherry picked from commit 2bb6fc9)
…and add final tests (elastic#17352) * Move Metricbeat azure module to GA and add final tests (elastic#17319) * temp * add tests and move to GA * changelog * fix (cherry picked from commit e1114f1) * fix changelog
What does this PR do?
beta
label withga
Why is it important?
Move the azure module to GA
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues