Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Hotfix #17358

Merged
merged 1 commit into from
Mar 31, 2020
Merged

CI Hotfix #17358

merged 1 commit into from
Mar 31, 2020

Conversation

urso
Copy link

@urso urso commented Mar 31, 2020

  • Bug

What does this PR do?

The Jenkinsfile rules prevent many tests that should have been run to
execute. This changes tries to unify rules between the Jenkinsfile and
travis setup a little more.

Example PR that should have triggered almost all CI jobs, but they've all been skipped: #17332

Why is it important?

I noticed that in some PRs required tests have not been run at all by Jenkins. This is an attempt to applying similar rules to Jenkinsfiles and Travis setup.

Checklist

~~- [ ] My code follows the style guidelines of this project

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.
    ~~

Related issues

The Jenkinsfile rules prevent many tests that should have been run to
execute. This changes tries to unify rules between the Jenkinsfile and
travis setup a little more.
steps {
makeTarget("Docs", "docs")
}
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this. The elasticsearch-ci/docs test is much more complete.

@urso urso merged commit c2a9055 into elastic:master Mar 31, 2020
@urso urso deleted the ci-hotfixes branch March 31, 2020 12:35
@urso urso mentioned this pull request Mar 31, 2020
5 tasks
@urso urso added the v7.8.0 label Mar 31, 2020
urso pushed a commit to urso/beats that referenced this pull request Mar 31, 2020
The Jenkinsfile rules prevent many tests that should have been run to
execute. This changes tries to unify rules between the Jenkinsfile and
travis setup a little more.

(cherry picked from commit c2a9055)
urso pushed a commit to urso/beats that referenced this pull request Mar 31, 2020
The Jenkinsfile rules prevent many tests that should have been run to
execute. This changes tries to unify rules between the Jenkinsfile and
travis setup a little more.

(cherry picked from commit c2a9055)
@urso urso mentioned this pull request Mar 31, 2020
5 tasks
@urso urso added the v7.7.0 label Mar 31, 2020
urso pushed a commit that referenced this pull request Mar 31, 2020
The Jenkinsfile rules prevent many tests that should have been run to
execute. This changes tries to unify rules between the Jenkinsfile and
travis setup a little more.

(cherry picked from commit c2a9055)
urso pushed a commit that referenced this pull request Mar 31, 2020
The Jenkinsfile rules prevent many tests that should have been run to
execute. This changes tries to unify rules between the Jenkinsfile and
travis setup a little more.

(cherry picked from commit c2a9055)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
The Jenkinsfile rules prevent many tests that should have been run to
execute. This changes tries to unify rules between the Jenkinsfile and
travis setup a little more.

(cherry picked from commit 01ca0ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants