Code

Fix issues with output reloading#17381

Code

Merged

ycombinator merged 34 commits intoelastic:masterelastic/beats:masterfrom ycombinator:bugfix-output-leaksycombinator/beats:bugfix-output-leaksCopy head branch name to clipboardApr 21, 2020

+540-257

Commits

Commits on Apr 20, 2020

• Refactoring: extracting common fields into worker struct

  ycombinator

  committed
  ccefba0

• More refactoring

  ycombinator

  committed
  7e5e57c

• Address goroutine leak in publisher

  ycombinator

  committed
  89aa8cb

• Workaround: add Connection: close header to prevent FD leaks

  ycombinator

  committed
  03db189

• Adding CHANGELOG entry

  ycombinator

  committed
  6d160f4

• Adding IdleConnTimeout setting

  ycombinator

  committed
  c8a16c6

• Close idle connections when ES client is closed

  ycombinator

  committed
  f28d0b7

• When closing worker, make sure to cancel in-flight batches

  ycombinator

  committed
  d9bc4e5

• Cancel batch + guard

  ycombinator

  committed
  5d3b10e

• [WIP] Adding output reload test

  ycombinator

  committed
  5c4daff

• More WIP

  ycombinator

  committed
  71b1d55

• Update test

  ycombinator

  committed
  9ce4b54

• Try to get test passing for client first

  ycombinator

  committed
  014fd25

• Make workqueue shared

  ycombinator

  committed
  5c5e48a

• Making tests pass

  ycombinator

  committed
  6227a1f

• Clean up

  ycombinator

  committed
  ffd0822

• Moving SeedFlag var to correct place

  ycombinator

  committed
  b97becc

• Clarifying comments

  ycombinator

  committed
  3aeebda

• Reducing the number of quick iterations

  ycombinator

  committed
  1208332

• Reducing quick iterations even more

  ycombinator

  committed
  2039344

• Trying just 1 iteration

  ycombinator

  committed
  8a03547

• Setting out to nil after sending batch if paused

  ycombinator

  committed
  e31e53a

• Restoring old order of operations in Set()

  ycombinator

  committed
  dbf275a

• proposal

  

  urso

  authored and

  ycombinator

  committed
  a36cbb1

• Do not copy mutex

  ycombinator

  committed
  229623f

• Remove debugging statements

  ycombinator

  committed
  f09c5e0

• Bumping up testing/quick max count on TestOutputReload

  ycombinator

  committed
  896505c

• Removing commented out helper function

  ycombinator

  committed
  a59a56e

• Simplifying retryer now that workqueue is used across output loads

  ycombinator

  committed
  041922b

• Renaming parameter

  ycombinator

  committed
  5ff7219

Commits on Apr 21, 2020

• Removing debugging variable

  ycombinator

  committed
  15a1383

• Reducing lower bound of random # of batches

  ycombinator

  committed
  6e10331

• Removing sigUnWait from controller

  ycombinator

  committed
  6a6680c

• Removing unused field

  ycombinator

  committed
  09ccd8d