Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace HOSTNAME with NODE_NAME when accessing Kubelet API #17469

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Replace HOSTNAME with NODE_NAME when accessing Kubelet API #17469

merged 1 commit into from
Apr 7, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Apr 3, 2020 •
edited
Loading

Follow up of #16063.

More info on elastic/helm-charts#471 (comment).

When hostNetwork: true these 2 variables are identical:

[root@gke-cluster-1-default-pool-d5378bbe-9kxv metricbeat]# env | grep NODE_NAME
NODE_NAME=gke-cluster-1-default-pool-d5378bbe-9kxv
[root@gke-cluster-1-default-pool-d5378bbe-9kxv metricbeat]# env | grep HOSTNAME
HOSTNAME=gke-cluster-1-default-pool-d5378bbe-9kxv

When not hostNetwork: true these 2 variables are like:

[root@metricbeat-q2dgr metricbeat]# env | grep NODE
NODE_NAME=gke-cluster-1-default-pool-d5378bbe-rvgw
[root@metricbeat-q2dgr metricbeat]# env | grep HOST
HOSTNAME=metricbeat-q2dgr

@ChrsMark
Replace HOSTNAME with NODE_NAME for consistency
b6dc7ce 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark added review [zube]: In Review v7.7.0 Team:Platforms Label for the Integrations - Platforms team v7.8.0 labels Apr 3, 2020
@ChrsMark ChrsMark requested a review from a team April 3, 2020 13:17
@ChrsMark ChrsMark self-assigned this Apr 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@ChrsMark ChrsMark changed the title Replace HOSTNAME with NODE_NAME for consistency Replace HOSTNAME with NODE_NAME when accessing Kubelet API Apr 3, 2020
@ChrsMark ChrsMark requested a review from exekias April 3, 2020 14:05
@ChrsMark ChrsMark added the needs_backport PR is waiting to be backported to other branches. label Apr 6, 2020
@ChrsMark ChrsMark merged commit 27a03f1 into elastic:master Apr 7, 2020
@ChrsMark ChrsMark mentioned this pull request Apr 7, 2020
Merged
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Apr 7, 2020
@ChrsMark
Replace HOSTNAME with NODE_NAME for consistency (elastic#17469)
f1417f8 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
(cherry picked from commit 27a03f1)
@ChrsMark ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label Apr 7, 2020
@ChrsMark ChrsMark mentioned this pull request Apr 7, 2020
Merged
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Apr 7, 2020
@ChrsMark
Replace HOSTNAME with NODE_NAME for consistency (elastic#17469)
fe0ff20 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
(cherry picked from commit 27a03f1)
ChrsMark added a commit that referenced this pull request Apr 7, 2020
@ChrsMark
Replace HOSTNAME with NODE_NAME for consistency (#17469) (#17565)
f26f1dd 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
(cherry picked from commit 27a03f1)
ChrsMark added a commit that referenced this pull request Apr 7, 2020
@ChrsMark
Replace HOSTNAME with NODE_NAME for consistency (#17469) (#17564)
6d6111b 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
(cherry picked from commit 27a03f1)
@ChrsMark ChrsMark mentioned this pull request Apr 8, 2020
Closed
@ChrsMark ChrsMark mentioned this pull request Aug 31, 2021
Closed
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@ChrsMark
Replace HOSTNAME with NODE_NAME for consistency (elastic#17469) (elas…
80d6aad 
…tic#17565)

Signed-off-by: chrismark <chrismarkou92@gmail.com>
(cherry picked from commit 690fd31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

Assignees

@ChrsMark ChrsMark

Labels
review Team:Platforms Label for the Integrations - Platforms team v7.7.0 v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrsMark @elasticmachine @exekias @andresrc