Cherry-pick #17424 to 7.x: [Metricbeat] Fix cloudwatch metricset missing tags collection #17477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #17424 to 7.x branch. Original message:
What does this PR do?
This PR is to fix cloudwatch metricset from missing tags when
tags.resource_type_filter
is given. When user tries to collect daily storage metrics and s3 bucket tags with the cloudwatch metricset, it will fail to collect tags. This is because for CloudWatch metrics from S3 buckets, they always haveStorageType
as dimension. Dimension and S3 bucket name are combined to be theidentifierValue
in cloudwatch metricset code. But when collecting tags, dimensionStorageType
is not collected. That's why there is a mismatch betweenidentifierValue
andresourceTagMap
.Why is it important?
This PR will fix tags collection for all namespaces that always have a dimension reported in CloudWatch metrics.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Related issues