Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent] Windows spawning process fix #17751

Merged

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Apr 16, 2020

What does this PR do?

When windows process is spawned its WD is set to agents WD. this fixes it so beat can pick up default config out of its directory

Why is it important?

Without this beat tries to lookup for default config e.g metricbeat.yml in an agents home dir. This config is not there so it fails.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Project:fleet)

Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph ph added [zube]: In Review needs_backport PR is waiting to be backported to other branches. review labels Apr 16, 2020
@michalpristas michalpristas merged commit 10de8be into elastic:master Apr 17, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request Apr 20, 2020
[Agent] Windows spawning process fix (elastic#17751)

(cherry picked from commit 10de8be)
ph pushed a commit that referenced this pull request Apr 21, 2020
[Agent] Windows spawning process fix (#17751)

(cherry picked from commit 10de8be)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs_backport PR is waiting to be backported to other branches. review [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants