Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Agent] Allow arm64 as a testing packages #17767

Merged
merged 4 commits into from
Apr 17, 2020
Merged

[Agent] Allow arm64 as a testing packages #17767

merged 4 commits into from
Apr 17, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented Apr 16, 2020 •
edited
Loading

We don't plan to release the arm64 package buts let's keep it as a
target.

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Make sure you are running go 1.10.13 and that your docker instance has more than 2 gb of memory assigned to it.

Related issues

Use cases

Screenshots

Logs

@ph
Allow arm64 as a testing packages
9c4f9d8 
We don't plan to release the arm64 package buts let's keep it as a
target.
@ph ph requested a review from ruflin April 16, 2020 18:08
@ph ph self-assigned this Apr 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph
Copy link
Contributor Author

ph commented Apr 16, 2020

@ruflin I've run into weird issues with mage when I was running a docker setup with 2gb of ram on my mac once I've bumped that to 4gb all the problems were gone. I have closed #17757 but I qill keep an eye open do a bit more tests on my side.

This was looking to be a rabbit hole in the runtime.

@ph ph changed the title Allow arm64 as a testing packages [Agent] Allow arm64 as a testing packages Apr 16, 2020
@ph ph added the needs_backport PR is waiting to be backported to other branches. label Apr 16, 2020
michalpristas
michalpristas approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we will need to discuss more about what we plan on supporting after this, if there will be more platforms we can do something like with packages.yml

@ph ph merged commit 6866def into elastic:master Apr 17, 2020
ph added a commit to ph/beats that referenced this pull request Apr 17, 2020
@ph
[Agent] Allow arm64 as a testing packages (elastic#17767)
8379945 
* Allow arm64 as a testing packages

We don't plan to release the arm64 package buts let's keep it as a
target.

* changelog`

* rm space

(cherry picked from commit 6866def)
@ph ph mentioned this pull request Apr 17, 2020
Merged
6 tasks
@ph ph added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 17, 2020
ph added a commit that referenced this pull request Apr 20, 2020
@ph
[Agent] Allow arm64 as a testing packages (#17767) (#17803)
3a5caa5 
* Allow arm64 as a testing packages

We don't plan to release the arm64 package buts let's keep it as a
target.



(cherry picked from commit 6866def)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

@ruflin ruflin Awaiting requested review from ruflin

Assignees

@ph ph

Labels
review v7.8.0 [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ph @elasticmachine @michalpristas