Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elatic Agent] Enable debug level logging for Metricbeat and Filebeat for Alpha #17935

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented Apr 23, 2020

What does this PR do?

Enable debug level logging for Metricbeat and Filebeat for Alpha

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph ph changed the title Enable debug level logging for Metricbeat and Filebeat for Alpha [Elatic Agent] Enable debug level logging for Metricbeat and Filebeat for Alpha Apr 23, 2020
@ph ph self-assigned this Apr 23, 2020
@ph ph requested review from michalpristas and ruflin April 23, 2020 12:54
@ph ph added elastic-agent needs_backport PR is waiting to be backported to other branches. labels Apr 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Any concerns around creating too much log data in FB / MB? I remember we have some defaults there.

@ph
Copy link
Contributor Author

ph commented Apr 23, 2020

This will create a lot of logs, I am going to do a followup I will still merge this so this unblock other teams.

@ph ph force-pushed the elastic-agent/debug-on-filebeat-metricbeat branch from d8bbec3 to a28d2a2 Compare April 23, 2020 16:38
@ph
Copy link
Contributor Author

ph commented Apr 23, 2020

rebased on master and pushed it again.. This should fix the jenkins issues with GVM, I presume.. since we didn't change anything. . that could trigger that problem.

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok for me but we need to start plan for this to be configurable. afaik debug is not part of any reloadables, this means it cannot be configured via grpc config change. requires work on beats side.

@ph
Copy link
Contributor Author

ph commented Apr 28, 2020

@michalpristas Can you create a beats issue for reloadable logging configuration? It might already exist.

@ph ph force-pushed the elastic-agent/debug-on-filebeat-metricbeat branch from a28d2a2 to 64826d5 Compare April 28, 2020 15:08
@ph
Copy link
Contributor Author

ph commented Apr 28, 2020

rebased because lint failed on filebeat.. ?

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@ph ph merged commit ac5cbf4 into elastic:master Apr 29, 2020
michalpristas pushed a commit to michalpristas/beats that referenced this pull request May 6, 2020
… for Alpha (elastic#17935)

* Enable debug level logging for Metricbeat and Filebeat for Alpha

* Changelog
michalpristas pushed a commit to michalpristas/beats that referenced this pull request May 6, 2020
… for Alpha (elastic#17935)

* Enable debug level logging for Metricbeat and Filebeat for Alpha

* Changelog
michalpristas added a commit that referenced this pull request May 6, 2020
… for Alpha (#17935) (#18305)

* Enable debug level logging for Metricbeat and Filebeat for Alpha

* Changelog

Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
michalpristas added a commit that referenced this pull request May 6, 2020
… for Alpha (#17935) (#18307)

* Enable debug level logging for Metricbeat and Filebeat for Alpha

* Changelog

Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
michalpristas added a commit to michalpristas/beats that referenced this pull request May 6, 2020
… for Alpha (elastic#17935) (elastic#18307)

* Enable debug level logging for Metricbeat and Filebeat for Alpha

* Changelog

Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_backport PR is waiting to be backported to other branches. review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants