Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run mage fmt update on filebeat #17947

Merged
merged 1 commit into from
Apr 23, 2020
Merged

run mage fmt update on filebeat #17947

merged 1 commit into from
Apr 23, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Apr 23, 2020 •
edited
Loading

What does this PR do?

Rerun mage fmt update in filebeat to fix CI. This is introduced in #17910.

[2020-04-23T14:58:45.299Z] Error: some files are not up-to-date. Run 'mage fmt update' then review and commit the changes. Modified: [filebeat/docs/fields.asciidoc]

[2020-04-23T14:58:45.299Z] ../libbeat/scripts/Makefile:151: recipe for target 'check' failed

[2020-04-23T14:58:45.299Z] make[1]: *** [check] Error 1

[2020-04-23T14:58:45.299Z] make[1]: Leaving directory '/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17943/src/github.com/elastic/beats/filebeat'

[2020-04-23T14:58:45.299Z] Makefile:98: recipe for target 'check' failed

[2020-04-23T14:58:45.299Z] make: *** [check] Error 1

@kaiyan-sheng kaiyan-sheng self-assigned this Apr 23, 2020
@kaiyan-sheng kaiyan-sheng added bug Team:Integrations Label for the Integrations team labels Apr 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@kaiyan-sheng kaiyan-sheng requested a review from leehinman April 23, 2020 17:45
ycombinator
ycombinator approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing. WFG.

leehinman
leehinman approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. sorry I missed that.

@kaiyan-sheng
Copy link
Contributor Author

Merging this PR. @leehinman will fix the failing test 😄in a separate PR. Thank you!!

[2020-04-23T18:20:09.716Z] + mage build unitTest

[2020-04-23T18:20:39.908Z] >> build: Building filebeat

[2020-04-23T18:21:09.946Z] >> go test: Unit Testing

[2020-04-23T18:22:10.460Z] FAILURES:

[2020-04-23T18:22:10.463Z] Package: github.com/elastic/beats/v7/filebeat/fileset

[2020-04-23T18:22:10.463Z] Test:    TestLoadManifestNginx

[2020-04-23T18:22:10.463Z] fileset_test.go:59: 

[2020-04-23T18:22:10.463Z] Error Trace:	fileset_test.go:59

[2020-04-23T18:22:10.463Z] Error:      	Not equal: 

[2020-04-23T18:22:10.463Z]             	expected: []string{"ingest/pipeline.yml"}

[2020-04-23T18:22:10.463Z]             	actual  : []string{"ingest/default.json"}

[2020-04-23T18:22:10.463Z]             	Diff:

[2020-04-23T18:22:10.463Z]             	--- Expected

[2020-04-23T18:22:10.463Z]             	+++ Actual

[2020-04-23T18:22:10.463Z]             	@@ -1,3 +1,3 @@

[2020-04-23T18:22:10.463Z]             	 ([]string) (len=1) {

[2020-04-23T18:22:10.463Z]             	- (string) (len=19) "ingest/pipeline.yml"

[2020-04-23T18:22:10.463Z]             	+ (string) (len=19) "ingest/default.json"

[2020-04-23T18:22:10.463Z]             	 }

[2020-04-23T18:22:10.463Z] Test:       	TestLoadManifestNginx

[2020-04-23T18:22:10.463Z] ----

[2020-04-23T18:22:10.463Z] Package: github.com/elastic/beats/v7/filebeat/fileset

[2020-04-23T18:22:10.463Z] Test:    TestGetInputConfigNginx

[2020-04-23T18:22:10.463Z] fileset_test.go:192: 

[2020-04-23T18:22:10.463Z] Error Trace:	fileset_test.go:192

[2020-04-23T18:22:10.463Z] Error:      	Not equal: 

[2020-04-23T18:22:10.463Z]             	expected: "filebeat-5.2.0-nginx-access-default"

[2020-04-23T18:22:10.463Z]             	actual  : "filebeat-5.2.0-nginx-access-pipeline"

[2020-04-23T18:22:10.463Z]             	Diff:

[2020-04-23T18:22:10.463Z]             	--- Expected

[2020-04-23T18:22:10.463Z]             	+++ Actual

[2020-04-23T18:22:10.463Z]             	@@ -1 +1 @@

[2020-04-23T18:22:10.463Z]             	-filebeat-5.2.0-nginx-access-default

[2020-04-23T18:22:10.463Z]             	+filebeat-5.2.0-nginx-access-pipeline

[2020-04-23T18:22:10.463Z] Test:       	TestGetInputConfigNginx

[2020-04-23T18:22:10.464Z] ----

[2020-04-23T18:22:10.464Z] Package: github.com/elastic/beats/v7/filebeat/fileset

[2020-04-23T18:22:10.464Z] Test:    TestGetInputConfigNginxOverrides

[2020-04-23T18:22:10.464Z] ----

[2020-04-23T18:22:10.464Z] Package: github.com/elastic/beats/v7/filebeat/fileset

[2020-04-23T18:22:10.464Z] Test:    TestGetInputConfigNginxOverrides/close_eof

[2020-04-23T18:22:10.464Z] fileset_test.go:220: 

[2020-04-23T18:22:10.464Z] Error Trace:	fileset_test.go:220

[2020-04-23T18:22:10.464Z]             				fileset_test.go:256

[2020-04-23T18:22:10.464Z] Error:      	Not equal: 

[2020-04-23T18:22:10.464Z]             	expected: "filebeat-5.2.0-nginx-access-default"

[2020-04-23T18:22:10.464Z]             	actual  : "filebeat-5.2.0-nginx-access-pipeline"

[2020-04-23T18:22:10.464Z]             	Diff:

[2020-04-23T18:22:10.464Z]             	--- Expected

[2020-04-23T18:22:10.464Z]             	+++ Actual

[2020-04-23T18:22:10.464Z]             	@@ -1 +1 @@

[2020-04-23T18:22:10.464Z]             	-filebeat-5.2.0-nginx-access-default

[2020-04-23T18:22:10.464Z]             	+filebeat-5.2.0-nginx-access-pipeline

[2020-04-23T18:22:10.464Z] Test:       	TestGetInputConfigNginxOverrides/close_eof

[2020-04-23T18:22:10.464Z] ----

[2020-04-23T18:22:10.464Z] Package: github.com/elastic/beats/v7/filebeat/fileset

[2020-04-23T18:22:10.464Z] Test:    TestGetPipelineNginx

[2020-04-23T18:22:10.464Z] fileset_test.go:279: 

[2020-04-23T18:22:10.464Z] Error Trace:	fileset_test.go:279

[2020-04-23T18:22:10.464Z] Error:      	Not equal: 

[2020-04-23T18:22:10.464Z]             	expected: "filebeat-5.2.0-nginx-access-default"

[2020-04-23T18:22:10.464Z]             	actual  : "filebeat-5.2.0-nginx-access-pipeline"

[2020-04-23T18:22:10.464Z]             	Diff:

[2020-04-23T18:22:10.464Z]             	--- Expected

[2020-04-23T18:22:10.464Z]             	+++ Actual

[2020-04-23T18:22:10.464Z]             	@@ -1 +1 @@

[2020-04-23T18:22:10.464Z]             	-filebeat-5.2.0-nginx-access-default

[2020-04-23T18:22:10.464Z]             	+filebeat-5.2.0-nginx-access-pipeline

[2020-04-23T18:22:10.464Z] Test:       	TestGetPipelineNginx

[2020-04-23T18:22:10.464Z] ----

[2020-04-23T18:22:10.464Z] Package: github.com/elastic/beats/v7/filebeat/scripts/tester

[2020-04-23T18:22:10.464Z] Test:    TestGetPipelinePath

[2020-04-23T18:22:10.464Z] main_test.go:48: Cannot find pipeline in ../../module/postgresql/log/ingest/pipeline.json

[2020-04-23T18:22:10.464Z] ----

[2020-04-23T18:22:10.464Z] SUMMARY:

[2020-04-23T18:22:10.464Z]   Fail:     6

[2020-04-23T18:22:10.464Z]   Skip:     0

[2020-04-23T18:22:10.464Z]   Pass:     464

[2020-04-23T18:22:10.464Z]   Packages: 21

[2020-04-23T18:22:10.464Z]   Duration: 56.946626567s

[2020-04-23T18:22:10.464Z]   Coverage Report: /private/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17947/src/github.com/elastic/beats/filebeat/build/TEST-go-unit.html

[2020-04-23T18:22:10.464Z]   JUnit Report:    /private/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17947/src/github.com/elastic/beats/filebeat/build/TEST-go-unit.xml

[2020-04-23T18:22:10.464Z]   Output File:     /private/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17947/src/github.com/elastic/beats/filebeat/build/TEST-go-unit.out

[2020-04-23T18:22:10.464Z] >> go test: Unit Test Failed

[2020-04-23T18:22:10.464Z] Error: go test failed: 6 test failures

script returned exit code 1

@kaiyan-sheng kaiyan-sheng merged commit 86c59c0 into elastic:master Apr 23, 2020
@kaiyan-sheng kaiyan-sheng deleted the fix_fb_fields branch April 23, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

@ycombinator ycombinator ycombinator approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
bug Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiyan-sheng @elasticmachine @ycombinator @leehinman