Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix attribute resolution in example #17955

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

dedemorton
Copy link
Contributor

What does this PR do?

Adds label to example text so that the {beatname_uc} attribute is correctly resolved. Also fixes a couple of minor style issues.

Why is it important?

Command example will not work as written.

Checklist

N/A

@blakerouse While I was fixing the attribute resolution, I made a couple of small style changes. Let me know if you have questions.

@dedemorton dedemorton added bug docs needs_backport PR is waiting to be backported to other branches. v7.7.0 labels Apr 23, 2020
@dedemorton dedemorton requested a review from blakerouse April 23, 2020 20:39
@dedemorton dedemorton self-assigned this Apr 23, 2020
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dedemorton dedemorton merged commit 7c1b39e into elastic:master Apr 24, 2020
@dedemorton dedemorton deleted the fix_var_cloudfoundry branch April 24, 2020 19:25
dedemorton added a commit to dedemorton/beats that referenced this pull request Apr 24, 2020
dedemorton added a commit to dedemorton/beats that referenced this pull request Apr 24, 2020
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Apr 24, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants