Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic-Agent] Do not require unnecessary configuration #18003

Merged
merged 22 commits into from
May 4, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Apr 27, 2020

What does this PR do?

This PR is based on #17960 and waiting for it to go in.

At the moment when we omit download, retry, process or management.mode section in config agent will panic and die.
This PR allows these section to be empty (skipped) and the only thing needed are configuration of what the user wants to monitor (output and sources)

Why is it important?

To ease up using of standalone agent and not requiring configuration options user does not even understand.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #17883

@michalpristas michalpristas added enhancement review needs_backport PR is waiting to be backported to other branches. [zube]: In Review Project:fleet Ingest Management:alpha1 Group issues for ingest management alpha1 labels Apr 27, 2020
@michalpristas michalpristas self-assigned this Apr 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Project:fleet)

@michalpristas michalpristas changed the title [Elastic-Agent] Allow no config [Elastic-Agent] Do not require unnecessary configuration Apr 27, 2020
@ph
Copy link
Contributor

ph commented Apr 27, 2020

This look OKay, but let's have #17960 in to test.

@ph ph marked this pull request as ready for review April 29, 2020 14:14
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 29, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 1795
Skipped 180
Total 1975

@michalpristas michalpristas requested a review from ph April 30, 2020 06:42
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with configuration in #17883 from a blank file. Events are sent to Elasticsearch, I also started ES without having Ingest manager creates any templates.

@michalpristas michalpristas merged commit facc0ad into elastic:master May 4, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request May 4, 2020
* log paths within data

* changelog

* removed file

* empty config allowed

* configuration up to date and unified

* changelog

* unified

* switched path

* unnecessary type specifier

* logs-output

* var run to data path

* inject run so meta.json is not created at root of data
michalpristas added a commit that referenced this pull request May 4, 2020
…8185)

* log paths within data

* changelog

* removed file

* empty config allowed

* configuration up to date and unified

* changelog

* unified

* switched path

* unnecessary type specifier

* logs-output

* var run to data path

* inject run so meta.json is not created at root of data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ingest Management:alpha1 Group issues for ingest management alpha1 needs_backport PR is waiting to be backported to other branches. [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Elastic Agent] Copied configuration from fleet yaml page doesn't work in stand alone.
3 participants