[Filebeat] Improve ECS categorization field mappings for netflow module #18108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
enhancement
Filebeat
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
the
needs_team
- event.category : make array and add network - event.type - related.ip Closes elastic#16135
leehinman
force-pushed
the
16135_netflow_ecs_1.4
branch
from
c328820 to
bda7330
Compare
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
andrewkroh
approved these changes
Apr 29, 2020
| if len(relatedIP) > 0 { | ||
| ecsRelated := common.MapStr{} | ||
| ecsRelated["ip"] = relatedIP | ||
| event.Fields["related"] = ecsRelated |
There was a problem hiding this comment.
Suggested change
| event.Fields["related"] = ecsRelated | |
| event.Fields["related"] = common.MapStr{"ip": relatedIP} |
4 tasks
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
May 4, 2020
…le (elastic#18108) * Improve ECS categorization field mappings for netflow module - event.category : make array and add network - event.type - related.ip Closes elastic#16135 (cherry picked from commit e6d4787)
leehinman
added a commit
that referenced
this pull request
May 4, 2020
andrewkroh
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds ECS categorization fields to netflow input. Specifically:
Why is it important?
ECS categorization fields improves usability of the data in the SIEM app and improves cross correlation between data sources.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues
Closes #16135