[docs] Fix indentation problems in processor examples #18115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedemorton
added
docs
review
needs_backport
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
the
needs_team
dedemorton
removed
the
needs_team
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
Are you sure these configuration snippets in the |
|
@kvch They original snippets do work, but they aren't "tidy" and and can't be pasted directly into an existing processors section without causing an error. I know this seems trivial, but invalid yaml files seem to trip people up quite a bit, and things like whitespace aren't always obvious. So our existing config files look like this: If you paste one of our processor snippets into this config without adjusting the indentation, you get: So in #16696, I suggested that we fix the regular config files (filebeat.yml etc) rather that all the docs, but @exekias pointed out that we use spaces everywhere else so it would be awkward to not use them under processors. I wasn't expecting there to be so many changes but since all the reference yaml files are generated from the same source, it wasn't as much work as it seems. |
kvch
approved these changes
May 4, 2020
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
May 4, 2020
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
May 4, 2020
andrewkroh
pushed a commit
that referenced
this pull request
May 4, 2020
dedemorton
added a commit
that referenced
this pull request
May 5, 2020
dedemorton
removed
the
needs_backport
2 tasks
dedemorton
added
the
needs_backport
dedemorton
removed
the
needs_backport
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16696
Makes docs and reference.yml files consistent with how processors are defined in the beats.yml files. This change makes it easier for users to copy/paste and avoids the situation where they might create invalid yaml.
Also fixes a few other minor issues I found while going through the processor docs.
TODO: