[Elastic Agent] Add stream.* to metrics and logs collected #18261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ensure that the stream.type, stream.dataset and stream.namespace are added to each logs or metrics collected by the Agent. Fixes: elastic#18203
ph
added
review
[zube]: In Review
elastic-agent
Ingest Management:alpha1
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
the
needs_team
ph
added
needs_backport
ph
commented
May 5, 2020
| @@ -199,6 +211,18 @@ func (o *Operator) getMonitoringMetricbeatConfig(output interface{}) (map[string | |||
| "period": "10s", | |||
| "hosts": hosts, | |||
| "index": "metrics-agent-default", | |||
| "processors": []map[string]interface{}{ | |||
There was a problem hiding this comment.
a slice of map make me always cringe a little.
ruflin
approved these changes
May 5, 2020
This seems to be a good default, that would be a painless script? Maybe create an issue. |
michalpristas
approved these changes
May 5, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
|
6 tasks
ph
added a commit
to ph/beats
that referenced
this pull request
May 5, 2020
…8261) * [Elastic Agent] Add stream.* to metrics and logs collected This PR ensure that the stream.type, stream.dataset and stream.namespace are added to each logs or metrics collected by the Agent. Fixes: elastic#18203 (cherry picked from commit 7b87db5)
ph
added
v7.8.0
and removed
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensure that the stream.type, stream.dataset and stream.namespace
are added to each logs or metrics collected by the Agent.
Fixes: #18203
What does this PR do?
Why is it important?
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs