[Fleet] Fix agent enrollment script to not create a new enrollment token #18365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
the
needs_team
nchaulet
commented
May 7, 2020
| @@ -30,19 +30,31 @@ function enroll(){ | |||
| if [[ -n "${FLEET_ENROLLMENT_TOKEN}" ]] && [[ ${FLEET_ENROLLMENT_TOKEN} == 1 ]]; then | |||
| apikey = "${FLEET_ENROLLMENT_TOKEN}" | |||
| else | |||
| enrollResp=$(curl -X POST ${KIBANA_HOST:-http://localhost:5601}/api/ingest_manager/fleet/enrollment-api-keys \ | |||
| enrollResp=$(curl -X GET ${KIBANA_HOST:-http://localhost:5601}/api/ingest_manager/fleet/enrollment-api-keys \ | |||
There was a problem hiding this comment.
this response return the list of API keys but not the secret API key that you can only get doing a specific request to the ressource
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
mtojek
reviewed
May 11, 2020
dev-tools/packaging/templates/docker/docker-entrypoint.elastic-agent.tmpl
Outdated
Show resolved
Hide resolved
|
Is this a bug that should also be backported to 7.8? |
|
Yes this should probably backported 👍 |
|
testing this today |
michalpristas
approved these changes
May 12, 2020
…e-fix-agent-enrollment-script
|
@michalpristas I am not sure why test are failing here, can I get some help? |
|
@nchaulet probably flakyness i restarted test, try merging with master |
|
@elasticmachine merge upstream |
…e-fix-agent-enrollment-script
|
failures do not seem related, locally libbeat passes, i think it's ok to get this in |
nchaulet
added a commit
to nchaulet/beats
that referenced
this pull request
May 13, 2020
nchaulet
added a commit
that referenced
this pull request
May 14, 2020
nchaulet
added a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This script is creating a new enrollment token associated to a non existing config (
defaultis not a valid id, the id of the default config is a random uuid)I updated this script to get the default enrollment token created during fleet setup instead.
Related to elastic/kibana#65669
Also created an issue on kibana elastic/kibana#65752 to not allow the creation of an enrollment token for a non existing agent config id.