Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo in serialized JSON property name #18420

Merged
merged 1 commit into from
May 11, 2020

Conversation

ycombinator
Copy link
Contributor

Fixes a typo in a field name introduced in #17992. See https://github.com/elastic/beats/pull/17992/files#r423112702.

@ycombinator ycombinator requested a review from chrisronline May 11, 2020 16:25
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 11, 2020
@ycombinator ycombinator added Feature:Stack Monitoring Team:Services (Deprecated) Label for the former Integrations-Services team labels May 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring (Stack monitoring)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@ycombinator ycombinator added [zube]: In Review v7.7.1 v7.8.0 v8.0.0 needs_backport PR is waiting to be backported to other branches. and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 11, 2020
@zube zube bot removed the needs_backport PR is waiting to be backported to other branches. label May 11, 2020
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

{
  "hits": {
    "hits": [
      {
        "_source": {
          "index_stats": {
            "primaries": {
              "bulk": {
                "avg_time_in_millis": 0,
                "avg_size_in_bytes": 0,
                "total_operations": 0,
                "total_time_in_millis": 0,
                "total_size_in_bytes": 0
              }
            },
            "total": {
              "bulk": {
                "total_operations": 0,
                "total_time_in_millis": 0,
                "total_size_in_bytes": 0,
                "avg_time_in_millis": 0,
                "avg_size_in_bytes": 0
              }
            }
          }
        }
      }
    ]
  }
}

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 3020
Skipped 756
Total 3776

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov
    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Result: FAILURE

    • Duration: 2 min 22 sec

    • Start Time: 2020-05-11T17:42:27.602+0000

    • log

@ycombinator ycombinator merged commit 704c67e into elastic:master May 11, 2020
@ycombinator ycombinator deleted the mb-es-index-fix-typo branch May 11, 2020 18:01
@ycombinator ycombinator added needs_backport PR is waiting to be backported to other branches. and removed v7.7.1 needs_backport PR is waiting to be backported to other branches. labels May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Stack Monitoring Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants