Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #18477 to 7.8: fix application_pool metricset reader after pdh changes #18478

Merged
merged 1 commit into from
May 13, 2020
Merged

Cherry-pick #18477 to 7.8: fix application_pool metricset reader after pdh changes #18478

merged 1 commit into from
May 13, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented May 13, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #18477 to 7.8 branch. Original message:

What does this PR do?

Fixes tests and implementation in the iis/application_pool after pdh changes

Why is it important?

successful build

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@narph
fix application_pool metricset reader after pdh changes (elastic#18477)
1f3a31d 
* fix

* changelog

* mage fmt update

(cherry picked from commit e20f856)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 13, 2020
@narph narph self-assigned this May 13, 2020
@narph narph added [zube]: In Review backport Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels May 13, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@zube zube bot removed the [zube]: In Review label May 13, 2020
kaiyan-sheng
kaiyan-sheng approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 365
Skipped 37
Total 402

@narph narph merged commit 33dee93 into elastic:7.8 May 13, 2020
@narph narph deleted the backport_18477_7.8 branch May 13, 2020 14:43
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels May 13, 2020
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@narph narph

Labels
backport Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @kaiyan-sheng