Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18350 to 7.8: Pick up version from libbeat #18578

Merged
merged 2 commits into from
May 18, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #18350 to 7.8 branch. Original message:

What does this PR do?

For historical reasons we were keeping track of our version ourselves which creates overhead for releases. Picking up version from libbeat keeps us in par with other beats we're releasing with

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

[Elastic Agent] Pick up version from libbeat (elastic#18350)
@michalpristas michalpristas self-assigned this May 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 15, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 15, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit dd5d525 into elastic:7.8 May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Ingest Management:alpha1 Group issues for ingest management alpha1 review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants