-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix byte counters for source/destination/server/client #18704
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
❕ Build Aborted
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Pinging @elastic/siem (Team:SIEM) |
❕ Build Aborted
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Fixed in #18525 |
What does this PR do?
The original code mixes source/destination/server/client for byte counters.
Original:
client.bytes: 32
destination.bytes: 32
server.bytes: 33
source.bytes: 33
But client is source, not destination.
Fix is:
client.bytes: 32
source.bytes: 32
server.bytes: 33
destination.bytes: 33
Why is it important?
Because with original code source and destination counters are wrong.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.