Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.8] Monitoring: only include X-Pack API params when appropriate (#18787) #18794

Merged
merged 1 commit into from
May 27, 2020

Conversation

ycombinator
Copy link
Contributor

Backports the following commits to 7.8:

* Only include X-Pack API params if we're going to be talking to the X-Pack API!

* Refactoring for testability
@ycombinator ycombinator added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels May 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 27, 2020
@elasticmachine
Copy link
Collaborator

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18794 opened]

  • Start Time: 2020-05-27T19:50:35.789+0000

  • Duration: 72 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 6303
Skipped 1047
Total 7350

Steps errors

Expand to view the steps failures

  • Name: Make -C filebeat testsuite
    • Description: make -C filebeat testsuite

    • Duration: 1 min 52 sec

    • Start Time: 2020-05-27T20:13:02.738+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-05-27T21:01:59.029Z] + FILE=auditbeat/build/coverage/full.cov
[2020-05-27T21:01:59.029Z] + [ -f auditbeat/build/coverage/full.cov ]
[2020-05-27T21:01:59.029Z] + FILE=filebeat/build/coverage/full.cov
[2020-05-27T21:01:59.029Z] + [ -f filebeat/build/coverage/full.cov ]
[2020-05-27T21:01:59.029Z] + FILE=heartbeat/build/coverage/full.cov
[2020-05-27T21:01:59.029Z] + [ -f heartbeat/build/coverage/full.cov ]
[2020-05-27T21:01:59.029Z] + FILE=libbeat/build/coverage/full.cov
[2020-05-27T21:01:59.029Z] + [ -f libbeat/build/coverage/full.cov ]
[2020-05-27T21:01:59.029Z] + FILE=metricbeat/build/coverage/full.cov
[2020-05-27T21:01:59.029Z] + [ -f metricbeat/build/coverage/full.cov ]
[2020-05-27T21:01:59.029Z] + FILE=packetbeat/build/coverage/full.cov
[2020-05-27T21:01:59.029Z] + [ -f packetbeat/build/coverage/full.cov ]
[2020-05-27T21:01:59.029Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-05-27T21:01:59.029Z] + [ -f winlogbeat/build/coverage/full.cov ]
[2020-05-27T21:01:59.029Z] + FILE=journalbeat/build/coverage/full.cov
[2020-05-27T21:01:59.029Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-05-27T21:02:01.485Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats
[2020-05-27T21:02:01.822Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-05-27T21:02:01.846Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Lint
[2020-05-27T21:02:02.010Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Filebeat-oss
[2020-05-27T21:02:02.170Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Winlogbeat-oss
[2020-05-27T21:02:02.324Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-05-27T21:02:02.486Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Dockerlogbeat
[2020-05-27T21:02:02.657Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Journalbeat-oss
[2020-05-27T21:02:02.819Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-05-27T21:02:02.981Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-05-27T21:02:03.145Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-05-27T21:02:03.303Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-05-27T21:02:03.475Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-05-27T21:02:03.648Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Heartbeat-oss
[2020-05-27T21:02:03.819Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Libbeat-x-pack
[2020-05-27T21:02:03.991Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-05-27T21:02:04.163Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Filebeat-x-pack-Windows
[2020-05-27T21:02:04.326Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Auditbeat-Linux
[2020-05-27T21:02:04.474Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Filebeat-Windows
[2020-05-27T21:02:04.636Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-05-27T21:02:04.802Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Packetbeat-oss
[2020-05-27T21:02:05.054Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-05-27T21:02:05.217Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-Windows
[2020-05-27T21:02:05.378Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-05-27T21:02:05.538Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-05-27T21:02:05.712Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-05-27T21:02:05.873Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Heartbeat-Windows
[2020-05-27T21:02:06.042Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Filebeat-x-pack
[2020-05-27T21:02:06.207Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Functionbeat-Windows
[2020-05-27T21:02:06.371Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Libbeat-oss
[2020-05-27T21:02:06.539Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Auditbeat-Windows
[2020-05-27T21:02:06.706Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Libbeat-crosscompile
[2020-05-27T21:02:06.872Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Libbeat-stress-tests
[2020-05-27T21:02:07.048Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-05-27T21:02:07.213Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-05-27T21:02:07.374Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-05-27T21:02:07.821Z] + cat
[2020-05-27T21:02:07.821Z] + /usr/local/bin/runbld ./runbld-script
[2020-05-27T21:02:07.821Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-05-27T21:02:14.409Z] runbld>>> runbld started
[2020-05-27T21:02:14.409Z] runbld>>> 1.6.11/a66728ff8f4356963772e6e6d2069392fa06acbe
[2020-05-27T21:02:16.325Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-18794' in order of occurrence in the config (last value wins).
[2020-05-27T21:02:17.709Z] runbld>>> Debug logging enabled.
[2020-05-27T21:02:17.709Z] runbld>>> Storing result
[2020-05-27T21:02:17.709Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-05-27T21:02:17.709Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200527210217-4CAA9708
[2020-05-27T21:02:17.709Z] runbld>>> Adding system facts.
[2020-05-27T21:02:18.650Z] runbld>>> Adding vcs info for the latest commit:  f3316cfa4377cf847992c9a70d4b7a9e7bc3e054
[2020-05-27T21:02:18.912Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-05-27T21:02:19.174Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-05-27T21:02:19.174Z] Processing JUnit reports with runbld...
[2020-05-27T21:02:19.174Z] + echo 'Processing JUnit reports with runbld...'
[2020-05-27T21:02:19.435Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-05-27T21:02:19.435Z] runbld>>> DURATION: 15ms
[2020-05-27T21:02:19.435Z] runbld>>> STDOUT: 40 bytes
[2020-05-27T21:02:19.435Z] runbld>>> STDERR: 49 bytes
[2020-05-27T21:02:19.435Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-05-27T21:02:19.435Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats
[2020-05-27T21:02:20.829Z] runbld>>> Storing build metadata: 
[2020-05-27T21:02:20.829Z] runbld>>> Adding test report.
[2020-05-27T21:02:20.829Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats
[2020-05-27T21:02:22.212Z] runbld>>> Found 96 test output files
[2020-05-27T21:02:22.212Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-05-27T21:02:22.472Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-05-27T21:02:23.415Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-05-27T21:02:23.415Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-05-27T21:02:23.415Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-05-27T21:02:23.415Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-cloudfoundry.xml
[2020-05-27T21:02:23.415Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-05-27T21:02:23.415Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-05-27T21:02:23.675Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 7200 Skipped: 844
[2020-05-27T21:02:23.936Z] runbld>>> Storing result
[2020-05-27T21:02:23.936Z] runbld>>> FAILURES: 0
[2020-05-27T21:02:24.197Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-05-27T21:02:24.197Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200527210217-4CAA9708
[2020-05-27T21:02:24.197Z] runbld>>> Email notification disabled by environment variable.
[2020-05-27T21:02:24.197Z] runbld>>> Slack notification disabled by environment variable.
[2020-05-27T21:02:30.506Z] Running on worker-395930 in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18794
[2020-05-27T21:02:30.671Z] [INFO] getVaultSecret: Getting secrets
[2020-05-27T21:02:30.735Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-27T21:02:33.098Z] + chmod 755 generate-build-data.sh
[2020-05-27T21:02:33.098Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18794/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18794/runs/1 FAILURE 4315873
[2020-05-27T21:02:33.098Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18794/runs/1/steps/?limit=10000 -o steps-info.json
[2020-05-27T21:02:34.565Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18794/runs/1/tests/?status=FAILED -o tests-errors.json

@ycombinator ycombinator merged commit 90ace69 into elastic:7.8 May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team [zube]: Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants