Removed typo "made" from the note #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was "To make made it even ..." before.
|
@jakommo Thanks for the typo fixed. I directly remove the branch as it was in the main repo. We normally work of a fork for PR's but I see that sometimes it is much simpler to directly do it in the same repo. |
|
@ruflin oh, I started the edit process by clicking the Edit button on the doc page and it only gave me the option to directly commit to master or create a branch. Didn't think about this being created in the main repo. Will fork it next time 😄 |
|
@jakommo I assumed so. Github magic. But TBH I think to not have to fork an just use the web interface to fix a typo is very convenient for people who do not work with the repo on a daily base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was "To make made it even ..." before.