Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for cleaning up vendor directory #1888

Merged
merged 2 commits into from
Jun 21, 2016
Merged

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jun 20, 2016

This scripts removes the unnecessary files from the vendor directory. As we check in the vendor directory the goal is to keep the number of files to a minimum and if changes are made to the dependency make sure that it is easy to review the relevant changes.

@ruflin ruflin added the review label Jun 20, 2016

# Removes unncessary files from the vendor directories
#
# A aist for files to be removed is used instead of excluding files.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/aist/list/

@ruflin
Copy link
Contributor Author

ruflin commented Jun 20, 2016

@urso Thanks for the review. New version pushed.

This scripts removes the unnecessary files from the vendor directory. As we check in the vendor directory the goal is to keep the number of files to a minimum and if changes are made to the dependency make sure that it is easy to review the relevant changes.
@ruflin
Copy link
Contributor Author

ruflin commented Jun 20, 2016

@urso As discussed, all the other files we should not be deleted are now also excluded by default for *.txt files.

@ruflin
Copy link
Contributor Author

ruflin commented Jun 20, 2016

jenkins, test it

# Removes unncessary files from the vendor directories
#
# A list for files to be removed is used instead of excluding files.
# The reason is that this that this makes the setup simpler and prevents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that this that this"

@urso urso merged commit ee266ad into elastic:master Jun 21, 2016
@ruflin ruflin deleted the cleanup-vendor branch June 21, 2016 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants