[Ingest Manager] Change monitoring defaults for agent #18927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
enhancement
review
Team:Ingest Management
Ingest Management:beta1
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
…as/beats into agent-default-monitoring-cfg
ruflin
approved these changes
Jun 4, 2020
| logs: true | ||
| # enables metrics monitoring | ||
| metrics: true | ||
| # settings.monitoring: |
There was a problem hiding this comment.
In Beats we tried not to have a space after # for the things that are actual settings. Like this commenting out is easier and it is more obvious what is a setting and what a description.
Also below we have for the comments two # which I think makes it less readable.
There was a problem hiding this comment.
will handle in separate PR
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Jun 4, 2020
[Ingest Manager] Change monitoring defaults for agent (elastic#18927)
6 tasks
michalpristas
added a commit
that referenced
this pull request
Jun 4, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
[Ingest Manager] Change monitoring defaults for agent (elastic#18927)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
At this point monitoring is disabled by default, this PR makes it enabled and removes the necessity to have monitoring configuration in a configuration file
Why is it important?
Less things user needs to worry about
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Continuation of #18226