Fix/overlapping tcp segments #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
force-pushed
the
fix/overlapping-tcp-segments
branch
from
cadbbc5
to
026d4fd
Compare
| delta := lastSeq - tcpStartSeq | ||
|
|
||
| // if 'overlap' already covered by previous packet -> return | ||
| if int(delta) >= len(pkt.Payload) { |
There was a problem hiding this comment.
Should we add at least a debug log message here?
There was a problem hiding this comment.
debug message is ok. but this is perfectly valid behavior.
There was a problem hiding this comment.
rethinking this case, it's impossible to trigger this condition due to tcpSeq already compared to lastSeq and if reset, packet is dropped.
|
LGTM. Worth backporting? |
|
Yeah. in presence of overlapping resends, application layer parser are likely to trip or generate panic. |
ruflin
added
the
needs_backport
|
I added the backport layer. There seem to be quite some packetbeat system tests that are failing ... |
urso
force-pushed
the
fix/overlapping-tcp-segments
branch
from
31634fb
to
18ebe01
Compare
Closed
urso
force-pushed
the
fix/overlapping-tcp-segments
branch
from
18ebe01
to
5401d12
Compare
urso
force-pushed
the
fix/overlapping-tcp-segments
branch
from
5401d12
to
c44d735
Compare
urso
pushed a commit
to urso/beats
that referenced
this pull request
Jun 27, 2016
* TCP table driven unit test * Fix tcp segments overlaps
tsg
pushed a commit
that referenced
this pull request
Jul 19, 2016
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* TCP table driven unit test * Fix tcp segments overlaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.