Rename filters with processors #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicasarbu
force-pushed
the
rename_filters_with_processors
branch
from
021070a to
e6ca419
Compare
|
jenkins, retest it |
| Shipper publisher.ShipperConfig `config:",inline"` | ||
| Output map[string]*common.Config `config:"output"` | ||
| Logging logp.Logging `config:"logging"` | ||
| Processors processors.ProcessorPluginConfig `config:"processors"` |
There was a problem hiding this comment.
let's rename ProcessorPluginConfig to PluginConfig to reduce stuttering.
|
LGTM |
monicasarbu
force-pushed
the
rename_filters_with_processors
branch
from
441029e to
a70f549
Compare
monicasarbu
force-pushed
the
rename_filters_with_processors
branch
from
a70f549 to
60ec3a6
Compare
|
Similar to metricbeat, I was planning to implement "filters / prospectors" on a prospector level to filter events early and simplify the configuration of different filters for each prospector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are planning to use filters not only to reduce the number of fields from the exported event, but also to enhance the event with external meta data, we decided to rename
filterswithprocessors.NOTE: In Metricbeat you can also define
filtersper module and this part is not adjusted by this PR.