Switch default level to INFO #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of elastic#1931 and fixes elastic#1734. Some things to note/discuss: * `-v` does nothing by default now. However, it's possible that you set it to error in the config file and then use -v to go back to info level at the CLI. So I kept the option. * the `logging.level: debug` from the default configuration also doesn nothing now, unless you also specify some selectors. So I added also a `logging.selectors: ["*"]` to the default short config. * While not all of elastic#1931 is done yet, I think we can proceed with the default level change to fix elastic#1734 and then we do more INFO/WARN cleanups in future PRs.
11 tasks
| @@ -686,7 +686,7 @@ output.elasticsearch: | |||
| #logging.level: error | |||
|
|
|||
| # Enable debug output for selected components. To enable all selectors use ["*"] | |||
| # Other available selectors are beat, publish, service | |||
| # Other available selectors are "beat", "publish", "service" | |||
| # Multiple selectors can be chained. | |||
| #logging.selectors: [ ] | |||
There was a problem hiding this comment.
Should we add here also "*"?
There was a problem hiding this comment.
It's not the default, but I can add it if you think it makes more sense.
There was a problem hiding this comment.
No, you are right. In the full we have always the defaults.
Perhaps it would be make sense to change our default here, because if you enable debug I would assume that it is somehow expected to output messages. But currently default = "no selectors" as far as I understand?
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Aug 9, 2016
Part of elastic#1931. The default log level was changed to INFO in PR elastic#1952, but the change wasn't reflected in the default configuration files. This fixes it. The issue was signaled in elastic#2183. Also fixes the logging level in the docs.
ruflin
pushed a commit
that referenced
this pull request
Aug 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1931 and fixes #1734.
Some things to note/discuss:
-vdoes nothing by default now. However, it's possible that youset it to error in the config file and then use -v to go back to
info level at the CLI. So I kept the option.
logging.level: debugfrom the default configuration alsodoesn nothing now, unless you also specify some selectors. So I added
also a
logging.selectors: ["*"]to the default short config.default level change to fix lack of logging running as service on Ubuntu #1734 and then we do more INFO/WARN cleanups
in future PRs.