Support protocol: Cassandra #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medcl
force-pushed
the
cassandra
branch
5 times, most recently
from
5f26019 to
9e4ce7e
Compare
|
jenkins, test it again, please |
| - package: https://github.com/go-inf/inf | ||
| version: v0.9.0 | ||
| - package: github.com/golang/snappy | ||
| version: d9eb7a3d35ec988b8585d4a0068e462c27d28380 |
|
run |
| } | ||
| cassandra.pub.results = results | ||
|
|
||
| isDebug = logp.IsDebug("http") |
|
Looks quite good. Just some minor issues. Have you considered to fork the 'framer' of from gocql (or refactor gocql a little to make Framer available)? Would be nice to have the backing CQL parser vendored instead code being copied right into the module. |
medcl
added
in progress
| logp.Debug("cassandra", "start to parse header") | ||
| } | ||
| if !p.buf.Avail(9) { | ||
| logp.Err("not enough head bytes, ignore") |
There was a problem hiding this comment.
this is no error, but an indicator no complete frame header being in buffer. downgrade to Debug
medcl
force-pushed
the
cassandra
branch
2 times, most recently
from
fbceb7b to
b647852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for this issue:
#1958