[Ingest Manager] Unroll on unauthorised #19722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
enhancement
review
Team:Ingest Management
Ingest Management:beta1
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
needs_team
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
blakerouse
reviewed
Jul 8, 2020
| return false | ||
| } | ||
|
|
||
| return strings.Contains(err.Error(), fleetapi.ErrInvalidAPIKey.Error()) |
There was a problem hiding this comment.
Is it not possible to unwrap the error and check for the specific error type?
Would prefer that over string matching.
There was a problem hiding this comment.
i spent some time trying to achieve that but with no luck, took a different path today , fresh mind helped
blakerouse
approved these changes
Jul 9, 2020
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Jul 14, 2020
[Ingest Manager] Unroll on unauthorised (elastic#19722)
6 tasks
michalpristas
added a commit
that referenced
this pull request
Jul 14, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
[Ingest Manager] Unroll on unauthorised (elastic#19722)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Followup to #19507
This PR detects invalid API token error coming from fleet and after
6times of retries with backoff in row (should take 5 minutes or so to avoid transient issues). On succ request counter is zeroed.When unroll is detected (and not coming from fleet) it is not acked but stored in action_store. Removing action store manually will enable agent to ping fleet again. Otherwise it detects it's unrolled on start and prevent talking to fleet
Why is it important?
When API is revoked agent is not notified about this and starts seeing errors. Agent does not know how to handle that and tries to kick fleet periodically
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.