Cleanup Filebeat code #1975
Merged
Cleanup Filebeat code #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| CloseEOF bool | ||
| Backoff time.Duration | ||
| MaxBackoff time.Duration | ||
| BackoffFactor int |
There was a problem hiding this comment.
I think I like BackoffDuration better, as we've got 3 configs with Backoff here. Alternatively:
type BackoffConfig struct {
Duration time.Duration
Max time.Duration
Factor float32
}
There was a problem hiding this comment.
The naming change is to make reader configs consitent with the harvester config names.
+1 on the suggested struct, but then we should have it in libbeat.
There was a problem hiding this comment.
This is what we currently have in libbeat: https://github.com/elastic/beats/blob/master/libbeat/common/backoff.go
There was a problem hiding this comment.
It doesn't have the factor as it is just uses *2. We should do a more generic cleanup across all beats in an other PR.
| @@ -39,6 +27,7 @@ func New(spooler *spooler.Spooler, prospectorConfigs []*common.Config) (*Crawler | |||
| return &Crawler{ | |||
| spooler: spooler, | |||
| prospectorConfigs: prospectorConfigs, | |||
| wg: sync.WaitGroup{}, | |||
* Cleanup variable names in filebeat.yml.j2 * Cleanup spooler * Unify variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simplifications / cleanup to the filebeat code.
Meta issue: #1913