Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow device ID to be equal to 0 on OpenBSD #1979

Merged
merged 2 commits into from
Jul 6, 2016

Conversation

andrewkroh
Copy link
Member

The OpenBSD build is failing on this test assertion.

In these tests the Filebeat process should die on its own due to the nature of the test cases. On OpenBSD python was failing due to `OSError: [Errno 3] No such process` and this fixes the issue.
@andrewkroh
Copy link
Member Author

I added a second commit to fix these failures.

. /home/vagrant/go/src/github.com/elastic/beats/filebeat/build/python-env/bin/activate; nosetests -w tests/system --processes=4 --process-timeout=90 -a '!integration'
.......S...........................................E...E.......S........
======================================================================
ERROR: In case a prospector is defined but doesn't contain any paths, prospector must return error which
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/go/src/github.com/elastic/beats/filebeat/tests/system/test_prospector.py", line 277, in test_no_paths_defined
    filebeat.check_kill_and_wait(exit_code=1)
  File "../../../libbeat/tests/system/beat/beat.py", line 79, in check_kill_and_wait
    self.kill()
  File "../../../libbeat/tests/system/beat/beat.py", line 60, in kill
    self.proc.terminate()
  File "/usr/local/lib/python2.7/subprocess.py", line 1559, in terminate
    self.send_signal(signal.SIGTERM)
  File "/usr/local/lib/python2.7/subprocess.py", line 1554, in send_signal
    os.kill(self.pid, sig)
OSError: [Errno 3] No such process

======================================================================
ERROR: In case no prospectors are defined, filebeat must shut down and report an error
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/go/src/github.com/elastic/beats/filebeat/tests/system/test_prospector.py", line 254, in test_shutdown_no_prospectors
    filebeat.check_kill_and_wait(exit_code=1)
  File "../../../libbeat/tests/system/beat/beat.py", line 79, in check_kill_and_wait
    self.kill()
  File "../../../libbeat/tests/system/beat/beat.py", line 60, in kill
    self.proc.terminate()
  File "/usr/local/lib/python2.7/subprocess.py", line 1559, in terminate
    self.send_signal(signal.SIGTERM)
  File "/usr/local/lib/python2.7/subprocess.py", line 1554, in send_signal
    os.kill(self.pid, sig)
OSError: [Errno 3] No such process

----------------------------------------------------------------------
Ran 72 tests in 36.834s

FAILED (SKIP=2, errors=2)

@ruflin ruflin merged commit 4a3276d into elastic:master Jul 6, 2016
@andrewkroh andrewkroh deleted the feature/openbsd-device-id branch July 15, 2016 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants