Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate wrong filebeat config combinations #2007

Merged
merged 1 commit into from
Jul 26, 2016

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jul 11, 2016

  • Check ignore_older and close_older
  • Check close_removed and clean_removed combination
  • Check clean_idle > ignore_older + scan_frequency

@ruflin ruflin added in progress Pull request is currently in progress. Filebeat Filebeat labels Jul 11, 2016
@ruflin
Copy link
Contributor Author

ruflin commented Jul 25, 2016

@urso I have some implementation issue here I was hoping perhaps you could help. close_removed is part of the harvester config and the prospector does not know about it. clean_removed is part of the prospector config and the harvester does not know about it. The problem is now how to verify that both are set. It would be easy to just add close_removed also to the prospector config just for the validation. At the same time I think it is really nice that we have the two separated and would like to keep it this way. Any alternative idea?

@ruflin ruflin force-pushed the filebeat-config-validation branch from 5530229 to a6dca5c Compare July 25, 2016 08:17
* Add ignore_older check
* Add clean_inactive check
@ruflin ruflin force-pushed the filebeat-config-validation branch from a6dca5c to 2a6237d Compare July 26, 2016 07:45
@ruflin ruflin added review and removed in progress Pull request is currently in progress. labels Jul 26, 2016
@tsg tsg merged commit fb80edf into elastic:master Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants