[Elastic Agent] Add ability to re-exec agent #20111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
removed
the
needs_team
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ----------------------
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
| return errors.New(err, "failed to query service") | ||
| } | ||
| if status.State == svc.Stopped { | ||
| err = service.Start() |
There was a problem hiding this comment.
do we need to handle case when service is set to auto-restart?
There was a problem hiding this comment.
It does handle this case, by checking the service.ProcessId with the previous servicePid. When the command is called the previous pid is sent in the arguments to the command. Inside the loop it checks if the service is stopped (if so it starts it, and exits) if its not stopped it checks the current service.ProcessId against the previous pid and if it is different then it means it was already restarted so we also exit.
|
CI failures are unrelated to this PR. |
29 tasks
3 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Jul 28, 2020
* Add ability to reexec on all platforms. * Get it working on Windows * Fix on mac. * Fix vet. * Update ShutdownChan to be receive only. (cherry picked from commit 5a37193)
blakerouse
added a commit
that referenced
this pull request
Jul 28, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* Add ability to reexec on all platforms. * Get it working on Windows * Fix on mac. * Fix vet. * Update ShutdownChan to be receive only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds the ability to re-exec Elastic Agent in the same PID and memory address space (on unix) and with in the same service on Windows (not same PID and address space).
This has been tested on Windows using
SIGINTand Windows services, but theSIGINTcatch is removed in the PR because it cannot be that way truly. Adding a way to perform this on Windows will occur in a follow up branch.Why is it important?
This is one of the steps to self-upgrading the Elastic Agent. This will also be used to allow reloading of the Elastic Agent when a configuration change that does not automatically get applied through the reloader.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works(very hard to unit test)[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
SIGHUPto process will perform shutdown of the application and the re-exec itself.How to test this PR locally
Start the
elastic-agentthen send SIGHUP.