[libbeat] Don't swallow Kibana index pattern errors #20121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
While running 'beat setup --dashboads' any errors that occur while importing the generated Kibana index pattern or silently ignored. This changes that by causing the dashboard setup to stop and return the error. Dashboards won't work without the index pattern anyways.
andrewkroh
force-pushed
the
bugfix/kibana-dashboard-error
branch
from
62d5efc to
b765766
Compare
andrewkroh
added
the
Team:Services
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/integrations-services (Team:Services) |
|
On a related note |
|
Looks like the index pattern issue was reported in #19965. |
kaiyan-sheng
approved these changes
Jul 21, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
andrewkroh
added
the
needs_backport
andrewstucki
approved these changes
Jul 21, 2020
|
None at this time. We've had a few in the past and they weren't removed for any good reason AFAIK. I think it was just that nobody was maintaining them. Previously we used Hound CI to comment, but it wasn't very configurable IIRC. And before that we had reviewdog running. I use golangci-lint locally when I'm making changes. I'd be interested in trying out their Github action on PRs. https://github.com/marketplace/actions/run-golangci-lint |
|
that would be nice, I just ran it over the whole codebase, there are a good number of ineffectual assignments/lack off error checks it found: https://gist.github.com/andrewstucki/5cfc32b8024ac23bd4ae1edb2bbb4565 |
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jul 23, 2020
While running 'beat setup --dashboads' any errors that occur while importing the generated Kibana index pattern or silently ignored. This changes that by causing the dashboard setup to stop and return the error. Dashboards won't work without the index pattern anyways. (cherry picked from commit 7a7279f)
6 tasks
andrewkroh
added
v7.9.0
and removed
needs_backport
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jul 23, 2020
While running 'beat setup --dashboads' any errors that occur while importing the generated Kibana index pattern or silently ignored. This changes that by causing the dashboard setup to stop and return the error. Dashboards won't work without the index pattern anyways. (cherry picked from commit 7a7279f)
6 tasks
andrewkroh
added a commit
that referenced
this pull request
Jul 23, 2020
While running 'beat setup --dashboads' any errors that occur while importing the generated Kibana index pattern or silently ignored. This changes that by causing the dashboard setup to stop and return the error. Dashboards won't work without the index pattern anyways. (cherry picked from commit 7a7279f)
andrewkroh
added a commit
that referenced
this pull request
Jul 23, 2020
While running 'beat setup --dashboads' any errors that occur while importing the generated Kibana index pattern or silently ignored. This changes that by causing the dashboard setup to stop and return the error. Dashboards won't work without the index pattern anyways. (cherry picked from commit 7a7279f)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
While running 'beat setup --dashboads' any errors that occur while importing the generated Kibana index pattern or silently ignored. This changes that by causing the dashboard setup to stop and return the error. Dashboards won't work without the index pattern anyways.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
) While running 'beat setup --dashboads' any errors that occur while importing the generated Kibana index pattern or silently ignored. This changes that by causing the dashboard setup to stop and return the error. Dashboards won't work without the index pattern anyways. (cherry picked from commit 543349c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While running 'beat setup --dashboads' any errors that occur while importing the generated Kibana index pattern or silently ignored.
This changes that by causing the dashboard setup to stop and return the error. Dashboards won't work without the index pattern anyways.
Why is it important?
Errors with the Kibana index pattern were undetected. The only hint of an error is that the index pattern doesn't exist in Kibana after setup.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Logs
2020-07-21T18:26:27.006-0400 ERROR instance/beat.go:935 Exiting: 1 error: error loading index pattern: returned 413 to import file: <nil>. Response: {"statusCode":413,"error":"Request Entity Too Large","message":"Payload content length greater than maximum allowed: 1048576"}