Update Beat launcher to pass beater config section to New #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
force-pushed
the
enh/beat-config-section
branch
from
a4f22d6 to
a83c3b0
Compare
urso
force-pushed
the
enh/beat-config-section
branch
from
7ad2a52 to
4b992ae
Compare
urso
added
review
and removed
blocked
in progress
| @@ -36,7 +36,7 @@ func (bt *{{cookiecutter.beat|capitalize}}) Run(b *beat.Beat) error { | |||
| logp.Info("{{cookiecutter.beat}} is running! Hit CTRL-C to stop it.") | |||
|
|
|||
| bt.client = b.Publisher.Connect() | |||
| ticker := time.NewTicker(bt.config.{{cookiecutter.beat|capitalize}}.Period) | |||
| ticker := time.NewTicker(bt.config.Period) | |||
|
LGTM |
|
Winlogbeat still seems to have some complaints here. |
|
yeah, winlogbeat checks toplevel configs. Unfortunatelly winlogbeat tests for |
|
jenkins, retest it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.