-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #20112 to 7.x: [libbeat] Fix write error in ensureWriter.Write #20144
Conversation
(cherry picked from commit 787144f)
Pinging @elastic/integrations (Team:Integrations) |
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ---------------------- Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Cherry-pick of PR #20112 to 7.x branch. Original message:
What does this PR do?
The internal helper
ensureWriter.Write
is supposed to keep writing as long as the encapsulated writer returns a retriable error, however the test is inverted in the current code and terminates on retriable errors / retries on permanent ones.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.