Small fixes #2037
Merged
Small fixes #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -343,7 +343,7 @@ Inside the loop, the Beat sleeps for a configurable period of time and then | |||
| captures the required data and sends it to the publisher. The publisher client is available as part of the Beat object | |||
| through the `client` variable. | |||
|
|
|||
| The event := common.MapStr{} stores the event in a json format, and bt.client.PublishEvent(event) ispublishing data to Elasticsearch. | |||
| The `event := common.MapStr{}` stores the event in a json format, and `bt.client.PublishEvent(event)` is publishing data to Elasticsearch. | |||
| In the generated Beat, there are three fields in the event, which is @timestamp, type and counter. | |||
There was a problem hiding this comment.
This sentence is missing the oxford comma (after "type").
|
LGTM, but I noticed one other very minor thing. |
monicasarbu
force-pushed
the
small_fixes_new_beat_docs
branch
from
03940b2 to
c7d0570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.