Make default path.X available in config file #2042
Conversation
urso
added
in progress
| @@ -209,7 +209,7 @@ filebeat.prospectors: | |||
|
|
|||
| # Name of the registry file. If a relative path is used, it is considered relative to the | |||
| # data path. | |||
| #filebeat.registry_file: registry | |||
| #filebeat.registry_file: ${path.data}/registry | |||
There was a problem hiding this comment.
Writing filebeat.registry_file: ${path.data}/registry will be equivalent with writing filebeat.registry_file: registry, right?
I like the version with ${path.data} as it's more explicit about where the file is searched. But we'll need to explain in the docs that these variables are automatically set somehow.
|
Code LGTM. There's a unit test failure at the moment. Unfortunately I think we don't have system tests for these, so I guess we'll need to do some manual tests to check that:
|
|
uh, we're missing |
|
@urso yeah, we don't have |
| @@ -238,6 +241,8 @@ func (b *Beat) configure() error { | |||
| return fmt.Errorf("error loading config file: %v", err) | |||
| } | |||
|
|
|||
| // init paths config: | |||
There was a problem hiding this comment.
Does that comment belong on line 251?
There was a problem hiding this comment.
line can be removed. comment left over from original failed (more complicated) approach.
Just for consistency. But as there is currently no usage for it, let's keep it out. |
|
Looks good on some brief manual testing. @urso happy to merge it, do you want to cleanup history or should I just squash it? |
No description provided.