Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Move to datastream instead of dataset #20420

Merged
merged 9 commits into from
Aug 6, 2020
Merged

[Ingest Manager] Move to datastream instead of dataset #20420

merged 9 commits into from
Aug 6, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Aug 4, 2020 •
edited
Loading

What does this PR do?

This PR moves away from dataset.* fields and uses datastream.* fields instead.
It also requires fleet to send configuration with new fields in inputs definition.

This PR includes config change on top of event decorators.

Why is it important?

elastic/integrations#213
elastic/elasticsearch#60592

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas self-assigned this Aug 4, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 4, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 4, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20420 updated]

  • Start Time: 2020-08-06T06:48:29.442+0000

  • Duration: 37 min 45 sec

@michalpristas michalpristas force-pushed the agent-datastream-only branch from abc1960 to f4f3527 Compare August 4, 2020 11:43
@michalpristas michalpristas mentioned this pull request Aug 5, 2020
Merged
6 tasks
@jen-huang jen-huang mentioned this pull request Aug 5, 2020
Merged
@michalpristas michalpristas marked this pull request as ready for review August 6, 2020 06:47
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@michalpristas
Copy link
Contributor Author

michalpristas commented Aug 6, 2020 •
edited
Loading

Tested OK with elastic/kibana#74414

tested basic scenario, assigning custom config
data_stream.* populated correctly and indices named according to rules

@ruflin
Copy link
Contributor

ruflin commented Aug 6, 2020

Also tested on my end and looks like it works as expected. I hope you mean data_stream.* ;-)

blakerouse
blakerouse approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you got all of them!

@michalpristas michalpristas merged commit 6fabb86 into elastic:master Aug 6, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request Aug 6, 2020
@michalpristas
[Ingest Manager] Move to datastream instead of dataset (elastic#20420)
1bc0e0b 
[Ingest Manager] Move to datastream instead of dataset (elastic#20420)
michalpristas added a commit to michalpristas/beats that referenced this pull request Aug 6, 2020
@michalpristas
[Ingest Manager] Move to datastream instead of dataset (elastic#20420)
66bc0f1 
[Ingest Manager] Move to datastream instead of dataset (elastic#20420)
This was referenced Aug 6, 2020
Merged
Merged
@jen-huang jen-huang mentioned this pull request Aug 6, 2020
Closed
michalpristas added a commit that referenced this pull request Aug 6, 2020
@michalpristas
[Ingest Manager] Move to datastream instead of dataset (#20420) (#20482)
65d488d 
[Ingest Manager] Move to datastream instead of dataset (#20420)
michalpristas added a commit that referenced this pull request Aug 6, 2020
@michalpristas
[Ingest Manager] Move to datastream instead of dataset (#20420) (#20481)
f65abed 
[Ingest Manager] Move to datastream instead of dataset (#20420)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@michalpristas @melchiormoulin
[Ingest Manager] Move to datastream instead of dataset (elastic#20420)
4cd64fc 
[Ingest Manager] Move to datastream instead of dataset (elastic#20420)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@michalpristas
[Ingest Manager] Move to datastream instead of dataset (elastic#20420) (
7905f34 
elastic#20482)

[Ingest Manager] Move to datastream instead of dataset (elastic#20420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels
enhancement Ingest Management:beta2 Group issues for ingest management beta2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalpristas @elasticmachine @ruflin @blakerouse