Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat]clone value when copy fields in processors #20491

Conversation

ianwoolf
Copy link
Contributor

@ianwoolf ianwoolf commented Aug 7, 2020

  • Bug

fix the bug mentioned in

What does this PR do?

clone value when copy field in processors to avoid crash.

Why is it important?

As explained in , a child-document of a map may point to it's root without deep copy.

Related issues

  • Relates with

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 7, 2020
@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
733dca0

Please, read and sign the above mentioned agreement if you want to contribute to this project

@botelastic
Copy link

botelastic bot commented Aug 7, 2020

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

❕ Build Aborted

The PR is not allowed to run in the CI yet

Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20491 opened]

  • Reason: The PR is not allowed to run in the CI yet

  • Start Time: 2020-08-07T06:57:43.698+0000

  • Duration: 4 min 47 sec

  • Commit: 733dca0

Steps errors

Expand to view the steps failures

  • Name: Error signal
    • Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

    • Duration: 0 min 0 sec

    • Start Time: 2020-08-07T07:01:18.894+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-08-07T07:01:22.761Z] Stage "Elastic Agent Mac OS X" skipped due to earlier failure(s)
[2020-08-07T07:01:22.775Z] Stage "Filebeat oss" skipped due to earlier failure(s)
[2020-08-07T07:01:22.790Z] Stage "Filebeat x-pack" skipped due to earlier failure(s)
[2020-08-07T07:01:22.807Z] Stage "Filebeat Mac OS X" skipped due to earlier failure(s)
[2020-08-07T07:01:22.821Z] Stage "Filebeat x-pack Mac OS X" skipped due to earlier failure(s)
[2020-08-07T07:01:22.835Z] Stage "Filebeat Windows" skipped due to earlier failure(s)
[2020-08-07T07:01:22.848Z] Stage "Filebeat x-pack Windows" skipped due to earlier failure(s)
[2020-08-07T07:01:22.861Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:22.869Z] Stage "Auditbeat oss Linux" skipped due to earlier failure(s)
[2020-08-07T07:01:22.885Z] Stage "Auditbeat crosscompile" skipped due to earlier failure(s)
[2020-08-07T07:01:22.899Z] Stage "Auditbeat oss Mac OS X" skipped due to earlier failure(s)
[2020-08-07T07:01:22.914Z] Stage "Auditbeat oss Windows" skipped due to earlier failure(s)
[2020-08-07T07:01:22.929Z] Stage "Auditbeat x-pack" skipped due to earlier failure(s)
[2020-08-07T07:01:22.944Z] Stage "Auditbeat x-pack Mac OS X" skipped due to earlier failure(s)
[2020-08-07T07:01:22.958Z] Stage "Auditbeat x-pack Windows" skipped due to earlier failure(s)
[2020-08-07T07:01:22.972Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:22.980Z] Stage "Libbeat x-pack" skipped due to earlier failure(s)
[2020-08-07T07:01:22.995Z] Stage "Metricbeat OSS Unit tests" skipped due to earlier failure(s)
[2020-08-07T07:01:23.009Z] Stage "Metricbeat OSS Go Integration tests" skipped due to earlier failure(s)
[2020-08-07T07:01:23.023Z] Stage "Metricbeat OSS Python Integration tests" skipped due to earlier failure(s)
[2020-08-07T07:01:23.037Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-08-07T07:01:23.044Z] Stage "Metricbeat crosscompile" skipped due to earlier failure(s)
[2020-08-07T07:01:23.061Z] Stage "Metricbeat Mac OS X" skipped due to earlier failure(s)
[2020-08-07T07:01:23.076Z] Stage "Metricbeat x-pack Mac OS X" skipped due to earlier failure(s)
[2020-08-07T07:01:23.092Z] Stage "Metricbeat Windows" skipped due to earlier failure(s)
[2020-08-07T07:01:23.108Z] Stage "Metricbeat x-pack Windows" skipped due to earlier failure(s)
[2020-08-07T07:01:23.122Z] Stage "Packetbeat OSS" skipped due to earlier failure(s)
[2020-08-07T07:01:23.129Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:23.137Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:23.144Z] Stage "Winlogbeat Windows x-pack" skipped due to earlier failure(s)
[2020-08-07T07:01:23.159Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:23.166Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:23.173Z] Stage "Generators" skipped due to earlier failure(s)
[2020-08-07T07:01:23.181Z] Stage "Kubernetes" skipped due to earlier failure(s)
[2020-08-07T07:01:23.514Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:23.525Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:23.536Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-08-07T07:01:23.547Z] Stage "Packetbeat OSS" skipped due to earlier failure(s)
[2020-08-07T07:01:23.557Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:23.568Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:23.579Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:23.591Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:23.602Z] Stage "Generators" skipped due to earlier failure(s)
[2020-08-07T07:01:24.778Z] Failed in branch Elastic Agent x-pack
[2020-08-07T07:01:24.789Z] Failed in branch Elastic Agent x-pack Windows
[2020-08-07T07:01:24.800Z] Failed in branch Elastic Agent Mac OS X
[2020-08-07T07:01:24.811Z] Failed in branch Filebeat oss
[2020-08-07T07:01:24.823Z] Failed in branch Filebeat x-pack
[2020-08-07T07:01:24.834Z] Failed in branch Filebeat Mac OS X
[2020-08-07T07:01:24.845Z] Failed in branch Filebeat x-pack Mac OS X
[2020-08-07T07:01:24.855Z] Failed in branch Filebeat Windows
[2020-08-07T07:01:24.866Z] Failed in branch Filebeat x-pack Windows
[2020-08-07T07:01:24.876Z] Failed in branch Auditbeat oss Linux
[2020-08-07T07:01:24.886Z] Failed in branch Auditbeat crosscompile
[2020-08-07T07:01:24.898Z] Failed in branch Auditbeat oss Mac OS X
[2020-08-07T07:01:24.909Z] Failed in branch Auditbeat oss Windows
[2020-08-07T07:01:24.920Z] Failed in branch Auditbeat x-pack
[2020-08-07T07:01:24.931Z] Failed in branch Auditbeat x-pack Mac OS X
[2020-08-07T07:01:24.942Z] Failed in branch Auditbeat x-pack Windows
[2020-08-07T07:01:24.953Z] Failed in branch Libbeat x-pack
[2020-08-07T07:01:24.964Z] Failed in branch Metricbeat OSS Unit tests
[2020-08-07T07:01:24.975Z] Failed in branch Metricbeat OSS Go Integration tests
[2020-08-07T07:01:24.985Z] Failed in branch Metricbeat OSS Python Integration tests
[2020-08-07T07:01:24.995Z] Failed in branch Metricbeat crosscompile
[2020-08-07T07:01:25.006Z] Failed in branch Metricbeat Mac OS X
[2020-08-07T07:01:25.017Z] Failed in branch Metricbeat x-pack Mac OS X
[2020-08-07T07:01:25.028Z] Failed in branch Metricbeat Windows
[2020-08-07T07:01:25.038Z] Failed in branch Metricbeat x-pack Windows
[2020-08-07T07:01:25.049Z] Failed in branch Winlogbeat Windows x-pack
[2020-08-07T07:01:25.059Z] Failed in branch Kubernetes
[2020-08-07T07:01:25.671Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:25.682Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:25.693Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-08-07T07:01:25.704Z] Stage "Packetbeat OSS" skipped due to earlier failure(s)
[2020-08-07T07:01:25.716Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:25.727Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:25.738Z] Stage "Generators" skipped due to earlier failure(s)
[2020-08-07T07:01:26.142Z] Failed in branch dockerlogbeat
[2020-08-07T07:01:26.152Z] Failed in branch Journalbeat
[2020-08-07T07:01:26.654Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:26.666Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:26.677Z] Stage "Packetbeat OSS" skipped due to earlier failure(s)
[2020-08-07T07:01:26.688Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-08-07T07:01:26.699Z] Stage "Generators" skipped due to earlier failure(s)
[2020-08-07T07:01:26.812Z] Failed in branch Metricbeat x-pack
[2020-08-07T07:01:26.823Z] Failed in branch Winlogbeat
[2020-08-07T07:01:27.335Z] Failed in branch Heartbeat
[2020-08-07T07:01:27.345Z] Failed in branch Libbeat
[2020-08-07T07:01:27.356Z] Failed in branch Packetbeat OSS
[2020-08-07T07:01:27.366Z] Failed in branch Functionbeat
[2020-08-07T07:01:27.367Z] Stage "Generators" skipped due to earlier failure(s)
[2020-08-07T07:01:27.578Z] Failed in branch Generators
[2020-08-07T07:01:29.819Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-20491
[2020-08-07T07:01:30.116Z] [INFO] getVaultSecret: Getting secrets
[2020-08-07T07:01:30.214Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-08-07T07:01:31.276Z] + chmod 755 generate-build-data.sh
[2020-08-07T07:01:31.276Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20491/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20491/runs/1 ABORTED 227307
[2020-08-07T07:01:31.277Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20491/runs/1/steps/?limit=10000 -o steps-info.json
[2020-08-07T07:01:31.827Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20491/runs/1/tests/?status=FAILED -o tests-errors.json
[2020-08-07T07:01:31.827Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20491/runs/1/log/ -o pipeline-log.txt

@ianwoolf ianwoolf closed this Aug 7, 2020
@ianwoolf ianwoolf deleted the pr-clone-value-when-copy_fields-in-processors branch August 7, 2020 12:57
@ianwoolf ianwoolf restored the pr-clone-value-when-copy_fields-in-processors branch August 7, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants