[Filebeat][Cisco Module] Adding various smaller hotfixes related to github issues #20565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_ids, fixing nat mapping and a few more
P1llus
added
enhancement
in progress
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
Still needs a few small fixes and tests before totally ready for a review, but any comments appreciated. |
P1llus
added
review
and removed
in progress
|
PR is now ready for Review. A few pointers that might come up:
|
x-pack/filebeat/module/cisco/asa/test/additional_messages.log-expected.json
Outdated
Show resolved
Hide resolved
x-pack/filebeat/module/cisco/asa/test/additional_messages.log-expected.json
Outdated
Show resolved
Hide resolved
x-pack/filebeat/module/cisco/asa/test/additional_messages.log-expected.json
Outdated
Show resolved
Hide resolved
x-pack/filebeat/module/cisco/asa/test/additional_messages.log-expected.json
Outdated
Show resolved
Hide resolved
marc-gr
pushed a commit
to marc-gr/beats
that referenced
this pull request
Aug 25, 2020
…ithub issues (elastic#20565) * applying fixes to existing message_ids, adding support for new message_ids, fixing nat mapping and a few more * adding the last missing fields * updating changelog * mage fmt update * Updating test data to be a bit more realistic instead of just localhost (cherry picked from commit 3f025e1)
6 tasks
6 tasks
marc-gr
pushed a commit
to marc-gr/beats
that referenced
this pull request
Aug 27, 2020
…ithub issues (elastic#20565) * applying fixes to existing message_ids, adding support for new message_ids, fixing nat mapping and a few more * adding the last missing fields * updating changelog * mage fmt update * Updating test data to be a bit more realistic instead of just localhost (cherry picked from commit 3f025e1)
andrewkroh
pushed a commit
that referenced
this pull request
Aug 27, 2020
…ithub issues (#20565) (#20770) * applying fixes to existing message_ids, adding support for new message_ids, fixing nat mapping and a few more * adding the last missing fields * updating changelog * mage fmt update * Updating test data to be a bit more realistic instead of just localhost (cherry picked from commit 3f025e1) Co-authored-by: Marius Iversen <pillus@chasenet.org>
marc-gr
added a commit
that referenced
this pull request
Aug 31, 2020
…ithub issues (#20565) (#20767) * applying fixes to existing message_ids, adding support for new message_ids, fixing nat mapping and a few more * adding the last missing fields * updating changelog * mage fmt update * Updating test data to be a bit more realistic instead of just localhost (cherry picked from commit 3f025e1) Co-authored-by: Marius Iversen <pillus@chasenet.org>
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…ithub issues (elastic#20565) * applying fixes to existing message_ids, adding support for new message_ids, fixing nat mapping and a few more * adding the last missing fields * updating changelog * mage fmt update * Updating test data to be a bit more realistic instead of just localhost
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ithub issues (elastic#20565) (elastic#20770) * applying fixes to existing message_ids, adding support for new message_ids, fixing nat mapping and a few more * adding the last missing fields * updating changelog * mage fmt update * Updating test data to be a bit more realistic instead of just localhost (cherry picked from commit 8739dae) Co-authored-by: Marius Iversen <pillus@chasenet.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a try to resolve some commonly reported issues and requests, together with a few small hotfixes, new testlog cases to catch these issues and generated new golden files for existing logs.
Overview of the changes:
Why is it important?
Resolves variously reported issues about the ingest pipelines and adds support for more message fields.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues