Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use older version of github.com/dop251/goja_nodejs #20586

Merged
merged 3 commits into from
Aug 14, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Aug 13, 2020

What does this PR do?

This PR pins the version of github.com/dop251/goja_nodejs.

Why is it important?

The recent update of this library leads to the following error when generating custom Beats:

mage GenerateCustomBeat
# github.com/dop251/goja_nodejs/require
/home/n/go/pkg/mod/github.com/dop251/goja_nodejs@v0.0.0-20200728182148-d8e650e3b24d/require/resolve.go:169:13: undefined: goja.StackFrame
/home/n/go/pkg/mod/github.com/dop251/goja_nodejs@v0.0.0-20200728182148-d8e650e3b24d/require/resolve.go:170:21: r.runtime.CaptureCallStack undefined (type *goja.Runtime has no field or method CaptureCallStack)
Error: error compiling magefiles

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kvch kvch added needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Services (Deprecated) Label for the former Integrations-Services team labels Aug 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 13, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 13, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20586 updated]

  • Start Time: 2020-08-13T14:06:46.918+0000

  • Duration: 74 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 17976
Skipped 1827
Total 19803

Steps errors

Expand to view the steps failures

  • Name: Install python3:3.8
    • Description:

    • Duration: 7 min 15 sec

    • Start Time: 2020-08-13T14:32:38.409+0000

    • log

@kvch kvch merged commit b5e0405 into elastic:master Aug 14, 2020
kvch added a commit to kvch/beats that referenced this pull request Aug 14, 2020
@kvch kvch added v7.10.0 and removed needs_backport PR is waiting to be backported to other branches. labels Aug 14, 2020
kvch added a commit to kvch/beats that referenced this pull request Aug 14, 2020
@kvch kvch added the v7.9.0 label Aug 14, 2020
kvch added a commit that referenced this pull request Aug 14, 2020
kvch added a commit that referenced this pull request Aug 26, 2020
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0 v7.10.0 [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants