windows/perfmon fix for There is more data to return than will fit in the supplied buffer
#20630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
narph
added
[zube]: In Review
needs_backport
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
sayden
approved these changes
Aug 24, 2020
narph
added a commit
to narph/beats
that referenced
this pull request
Aug 27, 2020
…n the supplied buffer` (elastic#20630) * mofidy doc * fix * changelog (cherry picked from commit 49e8024)
6 tasks
narph
added a commit
to narph/beats
that referenced
this pull request
Aug 27, 2020
…n the supplied buffer` (elastic#20630) * mofidy doc * fix * changelog (cherry picked from commit 49e8024)
6 tasks
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…n the supplied buffer` (elastic#20630) * mofidy doc * fix * changelog
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…n the supplied buffer` (elastic#20630) (elastic#20818) * mofidy doc * fix * changelog (cherry picked from commit 99cad76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In some cases the
PdhExpandWildCardPathWapi call will not retrieve the expanded buffer size initially so the next call will encounter thePDH_MORE_DATAerror since the specified size on the input is still less than the required size.If this is the case a fallback on the
PdhExpandCounterPathWapi is executed since it looks to act in a more stable manner. ThePdhExpandCounterPathWapi does come with some limitations but will satisfy most cases and return valid paths.Why is it important?
Will fix
There is more data to return than will fit in the supplied buffererrors.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues