Always add conditionals to all processor actions #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
in progress
urso
force-pushed
the
always-conditionals
branch
from
a087dbf to
0029b71
Compare
| return event, nil | ||
| } | ||
|
|
||
| func (f includeFields) Run(event common.MapStr) (common.MapStr, error) { |
There was a problem hiding this comment.
I assume the reference * was removed intentionally.
There was a problem hiding this comment.
yes, includeFields is basically []string.
|
Nice addition. |
processor registry automatically adds conditional support to registered actions by wrapping processor constructors with NewConditional.
urso
force-pushed
the
always-conditionals
branch
from
0029b71 to
32cba95
Compare
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processor registry automatically adds conditional support to registered actions
by wrapping processor constructors with NewConditional.
With this PR every processor action being registered automatically gains support for the
when-conditional clause without having to any any extra code. This simplifies existing processor actions code, by requiring actions to implement only the required actions instead of check, parsing, applying conditional configurations. Plus it ensures conditionals always work exactly the same for all available actions.