[Elastic Agent] Rename *ConfigChange to PolicyChange #20779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rename the ConfigChagne to PolicyChange for: - The internal type for the actions. - The handler - The introspections This depends on change on Kibana to return the new Type and the new "Policy" key.
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
needs_team
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
michalpristas
approved these changes
Sep 7, 2020
|
I've talked to @michalpristas and he will take it over from me. |
|
Hi @michalpristas, I have Kibana changes here: elastic/kibana#78221 The Kibana changes includes BWC for <= 7.9 agent. I tested changing policies with a 7.9.1 snapshot build of agent and it worked well. Could you verify BWC as well as with the agent changes in this PR? Thanks! |
|
@jen-huang tested with agent from this branch. it retrieves action of type |
ph
commented
Sep 23, 2020
| - Prevent closing closed reader {pull}20214[20214] | ||
| - Fix Windows service installation script {pull}20203[20203] | ||
| - Fix timeout issue stopping service applications {pull}20256[20256] | ||
| - Fix rename *ConfigChange to *PolicyChange to align on changes in the UI. {pull}20779[20779] |
There was a problem hiding this comment.
changelog vs changelog.next
3 tasks
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Sep 29, 2020
[Elastic Agent] Rename *ConfigChange to PolicyChange (elastic#20779) Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
6 tasks
michalpristas
added
the
needs_backport
michalpristas
added a commit
that referenced
this pull request
Sep 30, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 30, 2020
…ci-build-label-support * upstream/master: [JJBB] Set shallow cloning to 10 (elastic#21409) docs: add link to release notes for 7.9.2 (elastic#21405) (elastic#21419) docs: Prepare Changelog for 7.9.2 (elastic#21229) (elastic#21403) fix: mark flaky tests (elastic#21300) fix: use a fixed version of setuptools (elastic#21393) Move Kubernetes events metricset to its own block in reference config (elastic#21407) [libbeat] Enable WriteAheadLimit in the disk queue (elastic#21391) docs: fix apt/yum formatting (elastic#21362) Fix shutdown tracking in s3 input (elastic#21380) [libbeat] Fix position writing in the disk queue Add UBI 8 image to the dependencies report (elastic#21374) Fix debug message to show actual SQS message ID (elastic#20614) [Elastic Agent] Rename *ConfigChange to PolicyChange (elastic#20779) [Elastic Agent] Add install/uninstall sub-command (elastic#21206) [Filebeat][httpjson] Make httpjson use cursor input when using date cursor (elastic#20751) feat: prepare release pipelines (elastic#21238) Add IP validation to Security module (elastic#21325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rename the ConfigChagne to PolicyChange for:
This depends on change on Kibana to return the new Type and the new
"Policy" key.
The kibana API need to be adjusted to send the right action type and the right fields.
What does this PR do?
Why is it important?
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs