Unmarshal JSON numbers as ints by default #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
force-pushed
the
json_unmarshal_ints
branch
2 times, most recently
from
1eef37a to
a94e15a
Compare
The change modifies the unmarshaling logic to try parsing the numbers in an int64 first, and only on error parse to a float64. In practice, this means that e.g. 1 will become an int64 and 1.0 will become a float64. Fixes elastic#2038. Includes a system test to verify that ticket.
tsg
added
docs
Filebeat
|
LGTM |
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Jul 26, 2016
I realized that when rebasing elastic#2091 on top of elastic#2088 a JSON test was lost. This resurrects it.
ruflin
pushed a commit
that referenced
this pull request
Jul 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change modifies the unmarshaling logic to try parsing the numbers
in an int64 first, and only on error parse to a float64. In practice,
this means that e.g. 1 will become an int64 and 1.0 will become a
float64.
Fixes #2038